- Notifications
You must be signed in to change notification settings - Fork1
feat: check for tool updates when printing current version#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would display a notification about a new version being available before every command, not only when running the version command.
The update check should be non-blocking — if an error occurs during the check, a general warning should be shown without preventing the command from running.
Co-authored-by: Per Tillisch <accounts@perglass.com>
| err:=checkForUpdates() | ||
| iferr!=nil { | ||
| feedback.Warning("failed to check for updates: "+err.Error()) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we should check updates also in other commands, although we could start with this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do those files become executable? Can you revert this change?
MatteoPologrutoNov 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't know, I downloaded the artifact generated by the check-licenses workflow and committed the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's probably Windows or WSL. Can you chmod everything in .licenses to 644 again?
Uh oh!
There was an error while loading.Please reload this page.
Motivation
Users should know if a new version of the tool is available.
Change description
A message is printed if a new version of the tool is available when checking the current version:
Additional Notes
Reviewer checklist
main.