Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: build.options now have the full path to used platforms#3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
cmaglie wants to merge1 commit intoarduino:master
base:master
Choose a base branch
Loading
fromcmaglie:core_upgrade

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Previously, the path to the folder containing the platforms was used (for example,/home/cmaglie/.arduino15/packages instead of/home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6). This kept thebuild.options file unchanged even if a platform was updated, leading to a possible cache reuse even if a full rebuild is required.

What is the current behavior?

~/Arduino/Blink$ arduino-cli compile --build-path buildLo sketch usa 1438 byte (4%) dello spazio disponibile per i programmi. Il massimo è 32256 byte.Le variabili globali usano 184 byte (8%) di memoria dinamica, lasciando altri 1864 byte liberi per le variabili locali. Il massimo è 2048 byte.~/Arduino/Blink$ cat build/build.options.json {  "additionalFiles": "",  "compiler.optimization_flags": "",  "customBuildProperties": "",  "fqbn": "arduino:avr:uno",  "hardwareFolders": "/home/cmaglie/.arduino15/packages,/home/cmaglie/Workspace/sketchbook-cores-beta/hardware",  "otherLibrariesFolders": "/home/cmaglie/Workspace/sketchbook-cores-beta/libraries",  "sketchLocation": "/home/cmaglie/Arduino/Blink"}

What is the new behavior?

~/Arduino/Blink$ arduino-cli compile --build-path buildLo sketch usa 1438 byte (4%) dello spazio disponibile per i programmi. Il massimo è 32256 byte.Le variabili globali usano 184 byte (8%) di memoria dinamica, lasciando altri 1864 byte liberi per le variabili locali. Il massimo è 2048 byte.~/Arduino/Blink$ cat build/build.options.json {  "additionalFiles": "",  "compiler.optimization_flags": "",  "customBuildProperties": "",  "fqbn": "arduino:avr:uno",  "hardwareFolders": "/home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6,/home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6",  "otherLibrariesFolders": "/home/cmaglie/Workspace/sketchbook-cores-beta/libraries",  "sketchLocation": "/home/cmaglie/Arduino/Blink"}~/Arduino/Blink$

Does this PR introduce a breaking change, and istitled accordingly?

Other information

Previously the path to the folder containing the platforms was used,(for exmaple, `/home/cmaglie/.arduino15/packages` instead of`/home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6`).This kept the build.options unchanged even if a platform was updated,leading to a possible cache-reuse even if a full rebuild is required.
@cmagliecmaglie added type: enhancementProposed improvement topic: codeRelated to content of the project itself topic: build-processRelated to the sketch build process labelsNov 10, 2025
@cmagliecmaglie self-assigned thisNov 10, 2025
@codecov
Copy link

codecovbot commentedNov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.34%. Comparing base (28dbc33) to head (1b373d3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #3042      +/-   ##==========================================- Coverage   69.37%   69.34%   -0.04%==========================================  Files         241      241                Lines       18591    18590       -1     ==========================================- Hits        12898    12891       -7- Misses       4496     4503       +7+ Partials     1197     1196       -1
FlagCoverage Δ
unit69.34% <100.00%> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmagliecmaglie marked this pull request as ready for reviewNovember 10, 2025 18:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@cmagliecmaglie

Labels

topic: build-processRelated to the sketch build processtopic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cmaglie
[8]ページ先頭
©2009-2025 Movatter.jp