When running arduino-app-cli version instead of only returning the version of the currently run executable (the CLI) we should also return the version of the server (the daemon/service running and waiting for HTTP API requests).

Change description

This change make a version request to the running daemon and adds the output to thearduino-app-cli version command.
It also adds "daemon_version" and rename "appName" to "name" from the json output.

Additional Notes

Test done with a daemon with version 8.8.8-server-dev running on port 8080. The output is:

% ./arduino-app-cli versionWarning: cannot get the running daemon version on localhost:8800Arduino App CLI version 0.0.0-dev

% ./arduino-app-cli version --port 8080Arduino App CLI version 0.0.0-devdaemon version: 8.8.8-server-dev

./arduino-app-cli version --format=json {  "name": "Arduino App CLI",  "version": "0.0.0-dev",  "warnings": [    "Warning: cannot get the running daemon version on localhost:8800\n"  ]}

% ./arduino-app-cli version --port 8080 --format=json{  "name": "Arduino App CLI",  "version": "0.0.0-dev",  "daemon_version": "8.8.8-server-dev"}

./arduino-app-cli version  --port 1234 Warning: cannot get the running daemon version on localhost:1234Arduino App CLI version 0.0.0-dev

The http server part is unaffected:

% curl http://localhost:8080/v1/version{"version":"8.8.8-server-dev"}

Reviewer checklist

PR addresses a single concern.
PR title and description are properly filled.
Changes will be merged inmain.
Changes are covered by tests.
Logging is meaningful in case of troubleshooting.

Copy link

CLAassistant commentedNov 6, 2025•
edited
Loading

All committers have signed the CLA.

martacarbone added2 commits

November 6, 2025 10:07

Add the server version to arduino-app-cli version.

fd939c5

Add copyright header.

466245c

martacarbone force-pushed thecli_server_version branch from7484347 to466245cCompare

November 6, 2025 09:14

lucarin91 reviewed

Nov 6, 2025

View reviewed changes

Copy link

Contributor

lucarin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, I added some minor suggestions to make it more readable (in my opinion)

cmd/arduino-app-cli/version/version.go OutdatedShow resolvedHide resolved

cmd/arduino-app-cli/version/version.goShow resolvedHide resolved

Address review comments.

bf435c6

per1234 added the enhancementNew feature or request label

Nov 8, 2025

Fix lint.

a5d95ea

dido18 requested changes

Nov 10, 2025

View reviewed changes

Copy link

Contributor

dido18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would rename theserverVersion intodaemonVersion all over the place

cmd/arduino-app-cli/version/version_test.go OutdatedShow resolvedHide resolved

cmd/arduino-app-cli/version/version.go OutdatedShow resolvedHide resolved

cmd/arduino-app-cli/version/version.go Outdated

		returnnet.JoinHostPort(h,p),nil
		}

		funcgetServerVersion(httpClient http.Client,urlstring)string {

Copy link

Contributor

dido18Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It could be useful to log DEBUG/WARN message with the error of this check.

Proposal:
The function returns astring, error.
If there is an error, the caller logs it, assigns the "empty" daemon version and prints a generic "error on get daemon version" in the cli response.

cmd/arduino-app-cli/version/version.go Outdated

		}

		ifdaemonVersion=="" {
		returnresult,fmt.Errorf("cannot connect to %s",hostAndPort)

Copy link

Contributor

dido18Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This hardcoded error could be misleading if it's not a connection error.
See the proposal to return the error and log it in the comment below

dido18 reviewed

Nov 10, 2025

View reviewed changes

cmd/arduino-app-cli/version/version.go Outdated

		AppNamestring`json:"appName"`
		Versionstring`json:"version"`
		Namestring`json:"name"`
		ClientVersionstring`json:"client_version"`

Copy link

Contributor

dido18Nov 10, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thisclient_version is a breaking change in the JSON response.

Current:

GET http://127.0.0.1:8800/v1/version{"version":"v0.2.3"}

Proposal: leave theversion and add thename anddaemon_version

GET http://127.0.0.1:8800/v1/version{"name": "Arduino App CLI","version":"v0.2.3""daemon_version": "v0.2.3"  }

dido18 linked an issue

Nov 10, 2025

that may beclosed by this pull request

Improve thearduino-app-cli version command by adding the "server version"#31

Open

Address review

776bcca

lucarin91 reviewed

Nov 10, 2025

View reviewed changes

cmd/arduino-app-cli/version/version.go Outdated

Comment on lines 136 to 137

		serverMessage:=fmt.Sprintf("%s client version %s",
		ProgramName,r.ClientVersion)

Copy link

Contributor

lucarin91Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	serverMessage:= fmt.Sprintf("%s client version %s",
	ProgramName, r.ClientVersion)
	serverMessage:=fmt.Sprintf("%s client version %s",ProgramName,r.ClientVersion)

cmd/arduino-app-cli/version/version.go Outdated

Comment on lines 140 to 141

		serverMessage=fmt.Sprintf("%s\ndaemon version: %s",
		serverMessage,r.DaemonVersion)

Copy link

Contributor

lucarin91Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	serverMessage= fmt.Sprintf("%s\ndaemon version: %s",
	serverMessage, r.DaemonVersion)
	serverMessage=fmt.Sprintf("%s\ndaemon version: %s",serverMessage,r.DaemonVersion)

cmd/arduino-app-cli/version/version_test.go


		// Leverage the http.Client's RoundTripper
		// to return a canned response and bypass network calls.
		typeTripperfunc(http.Request) (http.Response,error)

Copy link

Contributor

lucarin91Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I usually prefer using the httptest module instead of mocking the http client

Define the port only as custom input.

7aba0e1

lucarin91 reviewed

Nov 11, 2025

View reviewed changes

cmd/arduino-app-cli/version/version.go OutdatedShow resolvedHide resolved

cmd/arduino-app-cli/version/version.go

Comment on lines +106 to +107

		resultMessage=fmt.Sprintf("%s\ndaemon version: %s",
		resultMessage,r.DaemonVersion)

Copy link

Contributor

lucarin91Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit

Suggested change

	resultMessage= fmt.Sprintf("%s\ndaemon version: %s",
	resultMessage, r.DaemonVersion)
	resultMessage=fmt.Sprintf("%s\ndaemon version: %s",resultMessage,r.DaemonVersion)

cmd/arduino-app-cli/version/version.go OutdatedShow resolvedHide resolved

martacarboneand others added3 commits

November 11, 2025 10:59

Update cmd/arduino-app-cli/version/version.go

a9b0ca2

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update cmd/arduino-app-cli/version/version.go

ef78764

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update cmd/arduino-app-cli/version/version.go

0f6e212

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

lucarin91 approved these changes

Nov 11, 2025

View reviewed changes

dido18 approved these changes

Nov 11, 2025

View reviewed changes

Labels

enhancement

New feature or request

6 participants

Movatterモバイル変換

Improve the arduino-app-cli version command by adding the "server version" #31#49

Are you sure you want to change the base?

Improve the arduino-app-cli version command by adding the "server version" #31#49

Conversation

martacarbone commentedNov 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Motivation

Change description

Additional Notes

Reviewer checklist

Uh oh!

CLAassistant commentedNov 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

lucarin91 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dido18 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dido18Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

dido18Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

dido18Nov 10, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lucarin91Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

lucarin91Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

lucarin91Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lucarin91Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

martacarbone commentedNov 6, 2025•
edited
Loading

CLAassistant commentedNov 6, 2025•
edited
Loading

dido18Nov 10, 2025•
edited
Loading