I've added those partitions in#226 because we need them in every board with a file system, so I put them in a common dtsi. I also need anmbr partition at 0. Can we align on this? I can add the missingairoc_firmware partition for you.

Sounds good, but note that Zephyr already has common QSPI partitioningupstream usingqspi_flash, so we need to keep that naming to minimize changes. Will submit needed changes on your PR in a moment!

I see that someone already added something very similar upstream, good! Note that it's missing the MBR partition though, we don't have to have it I guess, but not sure. Also, this requires updating the Zephyr fork, right? If that's not going to happen very soon, we could use the local common file for now until it gets updated.

@KurtE, Zephyr will enter feature freeze for 4.3 this week, and we will definitely update soon. But please use PRs for actual code review, let's not have them turn into discussions. Feel free to open a separate topic for that 🙂

I see that someone already added something very similar upstream, good! Note that it's missing the MBR partition though, we don't have to have it I guess, but not sure.

It was me 😅 I'll add it so it's more complete (I need to fix the wifi address there anyway).

Also, this requires updating the Zephyr fork, right? If that's not going to happen very soon, we could use the local common file for now until it gets updated.

We can surely import the commit, but it wasn't a clean cherry pick due to formatting changes in recent Zephyr. I only cared about the Giga for this PR, so I copied it in without thinking about your filesystem work.

It was me 😅 I'll add it so it's more complete (I need to fix the wifi address there anyway).

We only need the MBR partition to create it if it gets erased for some reason. I just wanted to match the old cores behavior as much as possible.

We can surely import the commit, but it wasn't a clean cherry pick due to formatting changes in recent Zephyr. I only cared about the Giga for this PR, so I copied it in without thinking about your filesystem work.

That works for me. I think you also need to add/rename theqspi_flash label for all boards, right? I saw it's missing for some boards. This should work for at least all the boards we want a file system for: C33, Giga, Portenta-H7, etc...

Alternatively, we can just use this temporarily:

https://github.com/arduino/ArduinoCore-zephyr/blob/53b3947b71ead7f71a28731395d76b10131dab3d/variants/common/arduino_flash_fs.dtsi

And when Zephyr is updated, I can just remove the duplicate partitions and include the upstream file instead. Note that the file also adds common fstab entries and disks, so it's going to be needed anyway.