Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix video for USB-C displays.#1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
leonardocavagnis merged 2 commits intoarduino:mainfromiabdalkader:fix_h7_video
Jul 10, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,12 +22,23 @@ Arduino_H7_Video Display(800, 480, GigaDisplayShield);

Image img_arduinologo(ENCODING_RGB16, (uint8_t *) texture_raw, 300, 300);

void error() {
while (true) {
digitalWrite(LEDR, LOW);
delay(500);
digitalWrite(LEDR, HIGH);
delay(500);
}
}

void setup() {
Display.begin();
if (Display.begin()) {
error();
}

Display.beginDraw();
Display.image(img_arduinologo, (Display.width() - img_arduinologo.width())/2, (Display.height() - img_arduinologo.height())/2);
Display.endDraw();
}

void loop() { }
void loop() { }
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,9 +11,20 @@
Arduino_H7_Video Display(800, 480, GigaDisplayShield);
//Arduino_H7_Video Display(1024, 768, USBCVideo);

void error() {
while (true) {
digitalWrite(LEDR, LOW);
delay(500);
digitalWrite(LEDR, HIGH);
delay(500);
}
}

void setup() {
Display.begin();

if (Display.begin()) {
error();
}

Display.beginDraw();
Display.background(255, 255, 255);
Display.clear();
Expand All@@ -34,4 +45,4 @@ void setup() {
Display.endDraw();
}

void loop() { }
void loop() { }
16 changes: 14 additions & 2 deletionslibraries/Arduino_H7_Video/examples/LVGLDemo/LVGLDemo.ino
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,10 +28,22 @@ static void set_slider_val(void * bar, int32_t val) {
lv_bar_set_value((lv_obj_t *)bar, val, LV_ANIM_ON);
}

void error() {
while (true) {
digitalWrite(LEDR, LOW);
delay(500);
digitalWrite(LEDR, HIGH);
delay(500);
}
}

void setup() {
Serial.begin(115200);

Display.begin();
if (Display.begin()) {
error();
}

TouchDetector.begin();

/* Create a container with grid 2x2 */
Expand DownExpand Up@@ -140,4 +152,4 @@ void setup() {
void loop() {
/* Feed LVGL engine */
lv_timer_handler();
}
}
7 changes: 2 additions & 5 deletionslibraries/Arduino_H7_Video/src/H7DisplayShield.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,10 +41,7 @@ int USBCVideoClass::init(int edidmode) {
}

//Read EDID
err_code = anx7625_dp_get_edid(0, &recognized_edid);
if(err_code < 0) {
return err_code;
}
anx7625_dp_get_edid(0, &recognized_edid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Instead of removing the error check, I’d suggest collecting all errors in a bitmask so we don’t stop at the first failure but still track what went wrong.

Example:

#define INIT_ERR_ANX7625_INIT      (1 << 0)#define INIT_ERR_WAIT_HPD_EVENT    (1 << 1)#define INIT_ERR_GET_EDID         (1 << 2)#define INIT_ERR_DP_START        (1 << 3)...int error_mask = 0;...err_code = anx7625_init(0);if (err_code < 0) {    error_mask |= INIT_ERR_ANX7625_INIT;}...return error_mask; // 0 if everything is OK, otherwise a bitmask with the failed steps

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can't return an error with EDID bit set, because it will stop the sketch, which is what we're trying to undo here. Or are you suggesting to check the mask in the sketch? A bit too much for a sketch maybe?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yes, I mean checking the mask in the sketch... but you're right. it's a bit too much :)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I could take a look at why EDID is failing, and try to fix it, then we won't need any of this, but can't be sure I'll be able to fix it. Apparently it has always been failing we just hadn't notice. Alternatively, we could just merge this and move on, it's up to you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

let's merge it! :)


//DSI Configuration
err_code = anx7625_dp_start(0, &recognized_edid, (enum edid_modes) edidmode);
Expand All@@ -68,4 +65,4 @@ int USBCVideoClass::getStatus() {
}

GigaDisplayShieldClass GigaDisplayShield;
USBCVideoClass USBCVideo;
USBCVideoClass USBCVideo;
[8]ページ先頭
©2009-2025 Movatter.jp