Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add virtual destructor to avoid compiler warning on undefined behavior#557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
gillesdegottex wants to merge1 commit intoarduino:masterfromgillesdegottex:virtdtor
Closed

Conversation

@gillesdegottex
Copy link

@gillesdegottexgillesdegottex commentedApr 8, 2024
edited
Loading

TheServer class is virtual (begin() is not defined).
Standard thus requires to have the destructor virtual, otherwise undefined behaviour is expected.

This PR suggest to fix this issue by adding a simple empty destructor.

@github-actions
Copy link

Memory usage change @be75fe7

Boardflash%RAM for global variables%
arduino:avr:LilyPadUSB0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:atmegang:cpu=atmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:atmegang:cpu=atmega80 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:bt:cpu=atmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:bt:cpu=atmega3280 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:chiwawa0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:circuitplay32u4cat0 - 00.0 - 0.00 - 0N/A
arduino:avr:diecimila:cpu=atmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:diecimila:cpu=atmega3280 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:esplora0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:ethernet0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:fio0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:gemma0 - 00.0 - 0.00 - 0N/A
arduino:avr:leonardo0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:leonardoeth0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:lilypad:cpu=atmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:lilypad:cpu=atmega3280 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:mega:cpu=atmega12800 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:mega:cpu=atmega25600 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:megaADK0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:micro0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:mini:cpu=atmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:mini:cpu=atmega3280 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:nano:cpu=atmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:nano:cpu=atmega3280 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:nano:cpu=atmega328old0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:one0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:pro:cpu=16MHzatmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:pro:cpu=16MHzatmega3280 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:pro:cpu=8MHzatmega1680 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:pro:cpu=8MHzatmega3280 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:robotControl0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:robotMotor0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:uno0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:unomini0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:unowifi0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:yun0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:avr:yunmini0 - 00.0 - 0.00 - 00.0 - 0.0
Click for full report table
Boardlibraries/EEPROM/examples/eeprom_clear
flash
%libraries/EEPROM/examples/eeprom_clear
RAM for global variables
%libraries/EEPROM/examples/eeprom_iteration
flash
%libraries/EEPROM/examples/eeprom_iteration
RAM for global variables
%libraries/EEPROM/examples/eeprom_update
flash
%libraries/EEPROM/examples/eeprom_update
RAM for global variables
%libraries/EEPROM/examples/eeprom_write
flash
%libraries/EEPROM/examples/eeprom_write
RAM for global variables
%libraries/EEPROM/examples/eeprom_crc
flash
%libraries/EEPROM/examples/eeprom_crc
RAM for global variables
%libraries/EEPROM/examples/eeprom_get
flash
%libraries/EEPROM/examples/eeprom_get
RAM for global variables
%libraries/EEPROM/examples/eeprom_put
flash
%libraries/EEPROM/examples/eeprom_put
RAM for global variables
%libraries/EEPROM/examples/eeprom_read
flash
%libraries/EEPROM/examples/eeprom_read
RAM for global variables
%libraries/SPI/examples/BarometricPressureSensor
flash
%libraries/SPI/examples/BarometricPressureSensor
RAM for global variables
%libraries/SPI/examples/DigitalPotControl
flash
%libraries/SPI/examples/DigitalPotControl
RAM for global variables
%libraries/Wire/examples/SFRRanger_reader
flash
%libraries/Wire/examples/SFRRanger_reader
RAM for global variables
%libraries/Wire/examples/digital_potentiometer
flash
%libraries/Wire/examples/digital_potentiometer
RAM for global variables
%libraries/Wire/examples/i2c_scanner
flash
%libraries/Wire/examples/i2c_scanner
RAM for global variables
%libraries/Wire/examples/master_reader
flash
%libraries/Wire/examples/master_reader
RAM for global variables
%libraries/Wire/examples/master_writer
flash
%libraries/Wire/examples/master_writer
RAM for global variables
%libraries/Wire/examples/slave_receiver
flash
%libraries/Wire/examples/slave_receiver
RAM for global variables
%libraries/Wire/examples/slave_sender
flash
%libraries/Wire/examples/slave_sender
RAM for global variables
%libraries/SoftwareSerial/examples/SoftwareSerialExample
flash
%libraries/SoftwareSerial/examples/SoftwareSerialExample
RAM for global variables
%libraries/SoftwareSerial/examples/TwoPortReceive
flash
%libraries/SoftwareSerial/examples/TwoPortReceive
RAM for global variables
%
arduino:avr:LilyPadUSB00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:atmegang:cpu=atmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:atmegang:cpu=atmega800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:bt:cpu=atmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:bt:cpu=atmega32800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:chiwawa00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:circuitplay32u4cat00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A00.00N/A
arduino:avr:diecimila:cpu=atmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:diecimila:cpu=atmega32800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:esplora00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:ethernet00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:fio00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:gemma00.00N/A00.00N/A00.00N/A00.00N/A
arduino:avr:leonardo00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:leonardoeth00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:lilypad:cpu=atmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:lilypad:cpu=atmega32800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:mega:cpu=atmega128000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:mega:cpu=atmega256000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:megaADK00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:micro00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:mini:cpu=atmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:mini:cpu=atmega32800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:nano:cpu=atmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:nano:cpu=atmega32800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:nano:cpu=atmega328old00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:one00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:pro:cpu=16MHzatmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:pro:cpu=16MHzatmega32800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:pro:cpu=8MHzatmega16800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:pro:cpu=8MHzatmega32800.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:robotControl00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:robotMotor00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:uno00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:unomini00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:unowifi00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:yun00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
arduino:avr:yunmini00.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.000.0
Click for full report CSV
Board,libraries/EEPROM/examples/eeprom_clear<br>flash,%,libraries/EEPROM/examples/eeprom_clear<br>RAM for global variables,%,libraries/EEPROM/examples/eeprom_iteration<br>flash,%,libraries/EEPROM/examples/eeprom_iteration<br>RAM for global variables,%,libraries/EEPROM/examples/eeprom_update<br>flash,%,libraries/EEPROM/examples/eeprom_update<br>RAM for global variables,%,libraries/EEPROM/examples/eeprom_write<br>flash,%,libraries/EEPROM/examples/eeprom_write<br>RAM for global variables,%,libraries/EEPROM/examples/eeprom_crc<br>flash,%,libraries/EEPROM/examples/eeprom_crc<br>RAM for global variables,%,libraries/EEPROM/examples/eeprom_get<br>flash,%,libraries/EEPROM/examples/eeprom_get<br>RAM for global variables,%,libraries/EEPROM/examples/eeprom_put<br>flash,%,libraries/EEPROM/examples/eeprom_put<br>RAM for global variables,%,libraries/EEPROM/examples/eeprom_read<br>flash,%,libraries/EEPROM/examples/eeprom_read<br>RAM for global variables,%,libraries/SPI/examples/BarometricPressureSensor<br>flash,%,libraries/SPI/examples/BarometricPressureSensor<br>RAM for global variables,%,libraries/SPI/examples/DigitalPotControl<br>flash,%,libraries/SPI/examples/DigitalPotControl<br>RAM for global variables,%,libraries/Wire/examples/SFRRanger_reader<br>flash,%,libraries/Wire/examples/SFRRanger_reader<br>RAM for global variables,%,libraries/Wire/examples/digital_potentiometer<br>flash,%,libraries/Wire/examples/digital_potentiometer<br>RAM for global variables,%,libraries/Wire/examples/i2c_scanner<br>flash,%,libraries/Wire/examples/i2c_scanner<br>RAM for global variables,%,libraries/Wire/examples/master_reader<br>flash,%,libraries/Wire/examples/master_reader<br>RAM for global variables,%,libraries/Wire/examples/master_writer<br>flash,%,libraries/Wire/examples/master_writer<br>RAM for global variables,%,libraries/Wire/examples/slave_receiver<br>flash,%,libraries/Wire/examples/slave_receiver<br>RAM for global variables,%,libraries/Wire/examples/slave_sender<br>flash,%,libraries/Wire/examples/slave_sender<br>RAM for global variables,%,libraries/SoftwareSerial/examples/SoftwareSerialExample<br>flash,%,libraries/SoftwareSerial/examples/SoftwareSerialExample<br>RAM for global variables,%,libraries/SoftwareSerial/examples/TwoPortReceive<br>flash,%,libraries/SoftwareSerial/examples/TwoPortReceive<br>RAM for global variables,%arduino:avr:LilyPadUSB,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:atmegang:cpu=atmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:atmegang:cpu=atmega8,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,arduino:avr:bt:cpu=atmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:bt:cpu=atmega328,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:chiwawa,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:circuitplay32u4cat,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/Aarduino:avr:diecimila:cpu=atmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:diecimila:cpu=atmega328,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:esplora,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:ethernet,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:fio,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:gemma,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,0,0.0,0,N/A,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,arduino:avr:leonardo,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:leonardoeth,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:lilypad:cpu=atmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:lilypad:cpu=atmega328,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:mega:cpu=atmega1280,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:mega:cpu=atmega2560,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:megaADK,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:micro,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:mini:cpu=atmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:mini:cpu=atmega328,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:nano:cpu=atmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:nano:cpu=atmega328,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:nano:cpu=atmega328old,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:one,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:pro:cpu=16MHzatmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:pro:cpu=16MHzatmega328,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:pro:cpu=8MHzatmega168,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:pro:cpu=8MHzatmega328,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:robotControl,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,arduino:avr:robotMotor,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,arduino:avr:uno,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:unomini,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:unowifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:yun,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:avr:yunmini,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@gillesdegottexgillesdegottex changed the titleadd virtual destructor to avoid warningadd virtual destructor to avoid compiler warning on undefined behaviorApr 8, 2024
@gillesdegottexgillesdegottex changed the titleadd virtual destructor to avoid compiler warning on undefined behaviorAdd virtual destructor to avoid compiler warning on undefined behaviorApr 8, 2024
@per1234per1234 added the bug labelApr 12, 2024
Copy link
Contributor

@per1234per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your pull request@gillesdegottex!

There is a related discussion here:

arduino/ArduinoCore-API#218

You can see here that the equivalent change was originally also proposed inarduino/ArduinoCore-API#218:

arduino/ArduinoCore-API@ac60f9c#diff-ccc5d3629d2ff77383b7da8d17e48c75a6a160ad6a48ce5832d0e93a4265a885R28

--- a/api/Server.h+++ b/api/Server.h@@ -25,6 +25,7 @@ namespace arduino {  class Server : public Print {   public:+    virtual ~Server() {}     virtual void begin() = 0; };

However, the proposal was adjusted per this comment:

arduino/ArduinoCore-API#218 (comment)

It is enough to add virtual destructor toPrint, becauseStream,Client,Server,HardwareI2C andHardwareSerial are inherited fromPrint

@gillesdegottex
Copy link
Author

gillesdegottex commentedApr 13, 2024
edited
Loading

Oh, my bad, I didn't see this similar PR. I'll close mine then and see if I can bring any 2 cents useful forAPI#218.

@per1234
Copy link
Contributor

No worries. The goal of my comment was only to make sure the related work in the other repository was given consideration (I don't have enough expertise in C++ to make a judgement in the specific approach that should be taken in this matter).

The intent behind thearduino/ArduinoCore-API project is to maintain a single copy of all the non architecture-specific core code. Although thearduino/ArduinoCore-API codebase is used in all the platforms Arduino has created recently, and the "Arduino SAMD Boards (32-bits ARM Cortex-M0+)" platform (which was created years before the establishment of thearduino/ArduinoCore-API project) has been ported to using it, this platform hasn't yet been ported (#329) and it is not clear when or if such a porting will be completed. So this pull request is not really a duplicate ofarduino/ArduinoCore-API#218 (though hopefully we should try to align the work in the two repositories).

gillesdegottex reacted with thumbs up emoji

@gillesdegottex
Copy link
Author

Thx for the detailed answer!
I'll add the virtual destructor in the meantime on my side, hoping this will get handled inarduino/ArduinoCore-API as already discussed.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@per1234per1234per1234 left review comments

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gillesdegottex@per1234

[8]ページ先頭

©2009-2025 Movatter.jp