Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork137
Introducing ErrorCode#253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
andreagilardoni wants to merge14 commits intoarduino:masterChoose a base branch fromandreagilardoni:error-codes
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+288 −30
Draft
Changes from1 commit
Commits
Show all changes
14 commits Select commitHold shift + click to select a range
c8a56d6 Introducing ErrorCode
andreagilardoni863ca66 Introducing ReturnValue
andreagilardoni6ee998a Added standard values for error codes from errno
andreagilardoni047d9a3 Added unit tests for Error codes
andreagilardoni5a417ea Added unit tests for Return Values
andreagilardonia553fae codestyle unification
andreagilardoni4ccc1ba Integrating error code class in api definitions
andreagilardoni9a9ef24 Integrating Return Value class in apis
andreagilardoni43a3d9c changing definition of destructor to use default
andreagilardoni0e21f4e adapting unit tests to use ReturnValue class
andreagilardoni57050bf fixup! Added standard values for error codes from errno
andreagilardonie034fa5 fixup! Introducing ErrorCode
andreagilardoni0048d5f fixup! Added unit tests for Error codes
andreagilardoni41f3284 fixup! Added unit tests for Return Values
andreagilardoniFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
changing definition of destructor to use default
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit43a3d9cae6886b5c51a8a618953c2589b5d95c8c
There are no files selected for viewing
2 changes: 1 addition & 1 deletionapi/HardwareCAN.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -54,7 +54,7 @@ namespace arduino | ||
| class HardwareCAN | ||
| { | ||
| public: | ||
| virtual ~HardwareCAN()= default; | ||
| /** | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.