Commitdd236bf

committed

Don't mess with the original in String::substring

Before, substring would (temporarily) add a \0 in the original string atthe end of the substring, so the substring could be copied into a newString object. However, now that the String::copy() method can work withnon-nul-terminated strings (by passing an explicit length), this trickis not needed and we can just call the copy method instead.

1 parent8431488 commitdd236bfCopy full SHA for dd236bf

File tree

1 file changed

-4

lines changed

api
- String.cpp

1 file changed

-4

lines changed

`‎api/String.cpp‎`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -632,10 +632,7 @@ String String::substring(unsigned int left, unsigned int right) const`
`632`	`632`	`String out;`
`633`	`633`	`if (left >= len)return out;`
`634`	`634`	`if (right > len) right = len;`
`635`		`-char temp = buffer[right];// save the replaced character`
`636`		`-buffer[right] ='\0';`
`637`		`-out = buffer + left;// pointer arithmetic`
`638`		`-buffer[right] = temp;//restore character`
	`635`	`+out.copy(buffer + left, right - left);`
`639`	`636`	`return out;`
`640`	`637`	`}`
`641`	`638`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitdd236bf

File tree

1 file changed

1 file changed

`‎api/String.cpp‎`

0 commit comments