Commit6197511

committed

Avoid overflowing parseFloat()'s internal 'value'

If more than 309 digits are provided to Stream::parseFloat() (more than39 on AVR), the internal variable 'value' would overflow to infinity. Weavoid this by not storing the parsed number as an integer-in-a-float.

1 parent91c5e29 commit6197511Copy full SHA for 6197511

File tree

1 file changed

-6

lines changed

api
- Stream.cpp

1 file changed

-6

lines changed

`‎api/Stream.cpp‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,9 +179,12 @@ float Stream::parseFloat(LookaheadMode lookahead, char ignore)`
`179`	`179`	`elseif (c =='.')`
`180`	`180`	`isFraction =true;`
`181`	`181`	`elseif(c >='0' && c <='9') {// is c a digit?`
`182`		`- value = value *10 + c -'0';`
`183`		`-if(isFraction)`
`184`		`- fraction *=0.1;`
	`182`	`+if(isFraction) {`
	`183`	`+ fraction *=0.1;`
	`184`	`+ value = value + fraction * (c -'0');`
	`185`	`+ }else {`
	`186`	`+ value = value *10 + c -'0';`
	`187`	`+ }`
`185`	`188`	`}`
`186`	`189`	`read();// consume the character we got with peek`
`187`	`190`	`c =timedPeek();`
`@@ -191,9 +194,6 @@ float Stream::parseFloat(LookaheadMode lookahead, char ignore)`
`191`	`194`	`if(isNegative)`
`192`	`195`	`value = -value;`
`193`	`196`
`194`		`-if(isFraction)`
`195`		`- value *= fraction;`
`196`		`-`
`197`	`197`	`return value;`
`198`	`198`	`}`
`199`	`199`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit6197511

File tree

1 file changed

1 file changed

`‎api/Stream.cpp‎`

0 commit comments