Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adds to install.sh#9959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
shawayush wants to merge2 commits intoarduino:master
base:master
Choose a base branch
Loading
fromshawayush:master
Open

Conversation

@shawayush
Copy link

Resolves issue#7846

per1234
per1234 previously requested changesMar 30, 2020
@shawayush
Copy link
Author

Hi! I have updated the changes

@per1234per1234 dismissed theirstale reviewMarch 30, 2020 07:24

Requested changes have been made. Thanks!

# Update desktop file and mime databases (if possible)
updatedbs_f() {

if [!-f"${HOME}/root/.config/mimeapps.list" ];then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • $[HOME}/root/.config/mimeapps.list folder doesn't look correct to me
  • chmod +x is wrong, this file is not supposed be executable

Finally, why you create an empty mimeapps.list? how is this supposed to fix#7846?
From what I read in#7846 there isxdg-mime that cannot create/root/.local/share/applications/mimeapps.list.new becuase the parent directory is nonexistent.

Are you able to reproduce the error reported in the issue#7846 ? If yes, have you tested this fix before submitting?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@cmaglie
yes, I was able to reproduce the error reported, and yes and I did the test before I submitted my PR, whatever PR I have given for this organization during the GSOC period, have been tested and reproduced the same, so that my PR may be merged efficiently without any problems. I am still working on one of the features in Arduino-cli. Though it might look wrong to you, I have tried my best to tackle that issue I encounter with it and came up with this reasonable solution, which apparently solves the issue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ar
and after adding this patch to the code, this is what is written in that particular file,mimeapps.list

@per1234per1234 changed the titleAdds to isntall.shAdds to install.shAug 1, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmagliecmagliecmaglie left review comments

@per1234per1234per1234 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shawayush@CLAassistant@cmaglie@per1234

[8]ページ先頭

©2009-2025 Movatter.jp