Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Adds to install.sh#9959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Adds to install.sh#9959
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
shawayush commentedMar 30, 2020
Hi! I have updated the changes |
| # Update desktop file and mime databases (if possible) | ||
| updatedbs_f() { | ||
| if [!-f"${HOME}/root/.config/mimeapps.list" ];then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$[HOME}/root/.config/mimeapps.listfolder doesn't look correct to mechmod +xis wrong, this file is not supposed be executable
Finally, why you create an empty mimeapps.list? how is this supposed to fix#7846?
From what I read in#7846 there isxdg-mime that cannot create/root/.local/share/applications/mimeapps.list.new becuase the parent directory is nonexistent.
Are you able to reproduce the error reported in the issue#7846 ? If yes, have you tested this fix before submitting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@cmaglie
yes, I was able to reproduce the error reported, and yes and I did the test before I submitted my PR, whatever PR I have given for this organization during the GSOC period, have been tested and reproduced the same, so that my PR may be merged efficiently without any problems. I am still working on one of the features in Arduino-cli. Though it might look wrong to you, I have tried my best to tackle that issue I encounter with it and came up with this reasonable solution, which apparently solves the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
CLAassistant commentedApr 9, 2021
|

Resolves issue#7846