NotificationsYou must be signed in to change notification settings
Fork7k
Star14.5k

Refactor Print.cpp for consistency#5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

roncapat wants to merge1 commit intoarduino:masterfromroncapat:roncapat-patch-1

Closed

Refactor Print.cpp for consistency#5816

roncapat wants to merge1 commit intoarduino:masterfromroncapat:roncapat-patch-1

Conversation

Copy link

Contributor

roncapat commentedJan 7, 2017

Uniformed parameters (str, num) across "print" and corresponding "println".
Reorder methods to better separate non-ln and ln versions.

Signed-off-by: Patrick Roncaglioloronca.pat@gmail.com

Refactor Print.cpp for consistency

aae4a7e

Uniformed parameters (str, num) across "print" and corresponding "println". Reorder methods to better separate non-ln and ln versions.Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

Copy link

Collaborator

matthijskooijman commentedJan 19, 2017

This looks like a sane cleanup to me.

This is related to (mostly in the sense that it touches the same code and will probably conflict) to#5829.

Copy link

ContributorAuthor

roncapat commentedJan 19, 2017

Ok, I'll wait for the#5829 to merge and then fix the patch in this PR

Copy link

Contributor

cousteaulecommandant commentedJan 20, 2017

#5829 actually removes println from Print.cpp (except for println(void)), so that weird order issue is already handled by that. The random arg names still persist though; it is true that they're a bit confusing.

Copy link

ContributorAuthor

roncapat commentedJan 20, 2017

I had a look to your PR (#5829), and I think it's a great cleanup. When it's merged, maybe I'll check for arg names refactor. I subscribed to your PR so I'll know when to rebase and start from updated sources.