matthijskooijman left a comment

CI run on windows produce the following error:D:\a\Arduino\Arduino\build\build.xml:365: java.nio.file.InvalidPathException: Illegal char <*> at index 42: D:\a\Arduino\Arduino\build\macosx\arduino-*.dmg

Previously the <input...> tag was removed with sed to avoid hitting enteron the version number prompt. We can just skip the dist step altogetherinstead.

It looks like that on Windows string builders use a default encoding thatis different from UTF-8.

This allows the library loader to find them even if arduino_debug.exe orarduino.exe is started from a different directory for example from thecommand prompt.

Previously while testing on Windows, if the process produces a lot ofoutput that is not consumed, the pr.Wait() call will never endbecause the OS doesn't have enough buffering.

For some reason the consolePane.getText() method returns the documenttext with single CR translated into OS native CR+LF. This will influencetest outcome since we check various combinations of CR and LF.

Wait for consumer thread to collect all output before returning fromcommand line run. This patch avoid a race condition (the test outputis checked before all the output is actually collected).