- Notifications
You must be signed in to change notification settings - Fork875
[COR-57] Remove extractCollection helper from step#22166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
markuspf wants to merge4 commits intochore/unify-vertex-refChoose a base branch
base:chore/unify-vertex-ref
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[COR-57] Remove extractCollection helper from step#22166
markuspf wants to merge4 commits intochore/unify-vertex-reffromchore/remove-extract-collection-helper-from-step
+21 −60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
jvolmer approved these changesDec 9, 2025
Contributor
jvolmer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, just a nitpicking
Comment on lines 29 to 34
| [[nodiscard]] auto extractCollectionName( | ||
| velocypack::HashedStringRef const& idHashed) | ||
| -> ResultT<std::pair<std::string, size_t>>; | ||
| [[nodiscard]] auto extractCollectionNameOrThrow( | ||
| velocypack::HashedStringRef const& vertexRef) -> std::string; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
probably personal taste: could also be member functions of VertexRef but his is also fine.
94c2ae2 to4e40c07Comparee36b2c6 toae01274Comparea42946e to65b6badCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Scope & Purpose
Removes some code duplication. Requires#22165 to be merged first, and has an enterprise counterpart,https://github.com/arangodb/enterprise/pull/1564
Note
Replaces per-step collection-name extraction with VertexRef::collectionName, updates PathValidator accordingly, removes redundant getCollectionName/extract helpers, and wires new VertexRef.cpp into build.
VertexRef::collectionName()and new implementation fileGraph/Types/VertexRef.cpp; include inGraph/Types/CMakeLists.txt.step.getVertex().collectionName()inPathValidator::evaluateVertexRestrictionwith error propagation.getCollectionName()andBaseStep::extractCollectionName; adjustClusterProviderStep,SingleServerProviderStep, and testMockGraphProvider::Stepto rely onVertexRefAPIs.WeightedTwoSidedEnumerator(setForbidden*signatures,searchDonedeclaration).Written byCursor Bugbot for commit5abb820. This will update automatically on new commits. Configurehere.