- Notifications
You must be signed in to change notification settings - Fork875
[COR-22] Improve crash dumps#22153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jbajic wants to merge51 commits intodevelChoose a base branch
base:devel
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+1,497 −99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
0947615 tob435b36CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Scope & Purpose
This PR improves crash dumps by adding additional diagnostic data and provides a REST API for crash dump management.
On crash,
CrashHandlerserializes recent API calls and AQL queries, and async registry state in the crash dump directoryThis provides valuable context about what the server was doing before the crash
REST API for Crash Dump Management. New endpoints under /_admin/server/crashes (requires admin privileges):
GET /_admin/crashes- List all crash dump directories (UUIDs)GET /_admin/crashes/{id}- Get contents of a specific crash dump (all files as JSON)DELETE /_admin/crashes/{id}- Delete a specific crash dumpCrash dumps are stored in
<database-directory>/crashes/<uuid>/Each crash contains
async-registry.json- Async operation state,ApiRecording.json- Recent API calls and AQL queries, andbacktrace.txtandsystem_info.txt.The reports of the most recent 10 crashes are being kept; when the limit is exceeded, the older ones are being removed during startup.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)