- Notifications
You must be signed in to change notification settings - Fork875
[Supervised AqlValue] Make functions use supervised AqlValue#22106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cpjulia wants to merge61 commits intofeature/supervised-aql-valueChoose a base branch fromfeature/supervised-aql-functions
base:feature/supervised-aql-value
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
61 commits Select commitHold shift + click to select a range
4695ddc Add resource monitor as argument to AqlValue
cpjulia8bf38cf Format and add getter for resource monitor in Functions
cpjuliab3f570c Add ResourceMonitor to ComputedValuesExpressionContext; Add getResour…
knakatasff4c98a3 Fix compilation errors
cpjulia7c96a1c Fix compilation errors
cpjuliaac12386 Add resource monitor to AqlValue ctor call
cpjuliaa80de9d Add resource monitor to IResearch callers that need to pass it
cpjulia4b44e5a Add ResourceMonitor* to DecayFunctions.cpp DistanceFunctions.cpp Dist…
knakatasf6132af1 Add resource monitor to remaining IResearh files
cpjulia349c88d Add ResourceMonitor* to those Functions
knakatasfa21a067 Change signature of convertToObject() of DistributeFunctions.cpp; Pas…
knakatasf98875a2 Add ResourceMonitor* to ComputedValues.cpp
knakatasf69bf641 Add ResourceMonitor* to Expression.cpp
knakatasff725133 Add monitor to expression contexts
cpjuliabf3392e Add monitor to expression
cpjulia2c5d770 Fix monitor usage in Expression, already had as member
cpjulia0c9e57a Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliad5c571e Add monitor usage to LateMaterializedExpressionContext
cpjuliaf62f392 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia1617e38 Add access to monitor in Variable
cpjulia2f49ac3 Add rm to missing ctor callers
cpjulia7692c69 Correct complier errors for Expression.cpp; Add ResourceMonitor* to C…
knakatasf42855b2 Format code
knakatasf5e0b8f4 Fixed typos
cpjuliaa5ceec2 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliad12b34d Attempt to fix memory leak failure
cpjulia371dc5b Add check for nullptr
cpjuliaaecb218 Added monitor support to tests
cpjuliab0b9ac7 Brought back wrong logic of hashing
cpjulia34bb289 Merge branch 'devel' of github.com:arangodb/arangodb into feature/sup…
cpjulia4b58613 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia3eef984 Change cloneDataAndMoveShadow to always steal the guard
cpjulia720ee57 Added fix for use-after-free in cloneDataAndMoveShadow
cpjuliabfc9715 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliaac2c304 Add special case for supervised slice in cloneDataAndMoveShadow
cpjulia7ea92bf Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia0f42608 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia1fe66cb Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliad7e9d31 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia049fe01 Remove special case for supervised slice from cloneDataAndMoveShadow
cpjulia8cad3f7 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia8ad3a1f Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia6e64bde Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia8222211 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia788a006 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliaa464c41 Merge remote-tracking branch 'origin/devel' into feature/supervised-a…
cpjulia7c01568 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia9e56a4f Merge branch 'feature/supervised-aql-functions' of github.com:arangod…
cpjulia16d876f Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliac6d2c9d Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia3ec2380 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliacdcb261 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia2812ca4 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliac76d91f Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia22afa88 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia653a0a4 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliaf48b51d Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia77d334e Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia9baaf97 Merge feature/supervised-aql-value
cpjulia7fe5b98 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjulia2e7fad9 Merge branch 'feature/supervised-aql-value' of github.com:arangodb/ar…
cpjuliaFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
7 changes: 3 additions & 4 deletionsarangod/Aql/AqlItemBlock.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletionsarangod/Aql/AqlValue.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletionsarangod/Aql/DocumentExpressionContext.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
19 changes: 11 additions & 8 deletionsarangod/Aql/Expression.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletionsarangod/Aql/ExpressionContext.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
93 changes: 70 additions & 23 deletionsarangod/Aql/Function/ArrayFunctions.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.