- Notifications
You must be signed in to change notification settings - Fork875
[Supervised AqlValue] Make AqlItemBlock use supervised AqlValue#22105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cpjulia wants to merge81 commits intofeature/supervised-aql-valueChoose a base branch fromfeature/supervised-aql-item-block
base:feature/supervised-aql-value
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[Supervised AqlValue] Make AqlItemBlock use supervised AqlValue#22105
cpjulia wants to merge81 commits intofeature/supervised-aql-valuefromfeature/supervised-aql-item-block
+4,158 −32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…db/arangodb into feature/supervised-aql-item-block
mchacki approved these changesNov 19, 2025
Member
mchacki left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
… for supervised slices in AqlItemBlock
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…pervisedMemoryTest.cpp
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…db/arangodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…ryTest.cpp and AqlItemBlock.cpp
…db/arangodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
…db/arangodb into feature/supervised-aql-item-block
…angodb into feature/supervised-aql-item-block
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR makes use of#22034 by passing the resource monitor as argument to the AqlValue constructors in AqlItemBlock.cpp
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)