- Notifications
You must be signed in to change notification settings - Fork875
Fix a race when collecting list ongoing transactions.#22042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:devel
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e19ad4c to40ffb39CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Merge error and there is no code change in the PR anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Simran-B Unfortunately this fix attempt is invalid and I need to find a different solution, but still need more time for it. That's why I converted this PR to a draft.
Scope & Purpose
The GET /_api/transaction API was missing a lock which could lead to undefined behavior if a transaction would update its state at the same time while we are collecting its details.
Checklist
Tests
I was thinking about adding a regression test, but it is only a small change and designing a test for this specific issue would have been very akward because we need to jump through a lot of hoops to artifically construct the relevant situation.
📖 CHANGELOG entry made