Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ZEPPELIN-6384] Fix dropdown menu item links not clickable in full area#5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tbonelee wants to merge1 commit intoapache:master
base:master
Choose a base branch
Loading
fromtbonelee:fix-dropdown-link

Conversation

@tbonelee
Copy link
Contributor

What is this PR for?

Summary

  • Fixed dropdown menu items in header where only text was clickable instead of the full item area
  • Changed routerLinkActive to nzMatchRouter for proper NG-ZORRO integration
  • Added CSS pseudo-element to expand clickable area of anchor tags

Cause

  • Likely due to NG-ZORRO dropdown menu item anchor tag style changes that reduced the clickable area to just the text content.

Changes

  • Updatedheader.component.html: ReplacerouterLinkActive withnzMatchRouter directive
  • Updatedglobal.less: Add::before pseudo-element to.ant-dropdown-menu-item > a to expand clickable area using absolute positioning

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6384

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Contributor

@dididydididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@dididydididydididy approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbonelee@dididy
[8]ページ先頭
©2009-2025 Movatter.jp