- Notifications
You must be signed in to change notification settings - Fork2.8k
[ZEPPELIN-6373] Add E2E tests about share area#5114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ece19b8 to8684e2cCompare
tbonelee left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR! Test scenarios look good and are clear.
I've also added several commits that remove unused codes. If they make sense to you, please feel free to incorporate them.
https://github.com/tbonelee/zeppelin/commits/PR_5114-refactor/
Thanks!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| test('Given Create Note modal is open, When entering custom note name and creating, Then new note should be created successfully', async ({ | ||
| page | ||
| }) => { | ||
| const uniqueName = `Test Note ${Date.now()}`; | ||
| await noteCreateModal.setNoteName(uniqueName); | ||
| await noteCreateModal.clickCreate(); | ||
| await page.waitForURL(/notebook\//); | ||
| expect(page.url()).toContain('notebook/'); | ||
| }); | ||
| test('Given Create Note modal is open, When entering note name with folder path, Then note should be created in folder', async ({ | ||
| page | ||
| }) => { | ||
| const folderPath = `/TestFolder/SubFolder`; | ||
| const noteName = `Note ${Date.now()}`; | ||
| const fullPath = `${folderPath}/${noteName}`; | ||
| await noteCreateModal.setNoteName(fullPath); | ||
| await noteCreateModal.clickCreate(); | ||
| await page.waitForURL(/notebook\//); | ||
| expect(page.url()).toContain('notebook/'); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It would be better if we could verify the note name and path.
| const hasError = await noteImportModal.isErrorAlertVisible(); | ||
| if (hasError) { | ||
| const errorMessage = await noteImportModal.getErrorMessage(); | ||
| expect(errorMessage).toBeTruthy(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there any reason for this to be verified conditionally?
b6dbb72 to1a1cd06Compare
What is this PR for?
ABOUT_ZEPPELIN:'src/app/share/about-zeppelin/about-zeppelin.component',
CODE_EDITOR:'src/app/share/code-editor/code-editor.component',
FOLDER_RENAME:'src/app/share/folder-rename/folder-rename.component',
HEADER:'src/app/share/header/header.component',
NODE_LIST:'src/app/share/node-list/node-list.component',
NOTE_CREATE:'src/app/share/note-create/note-create.component',
NOTE_IMPORT:'src/app/share/note-import/note-import.component',
NOTE_RENAME:'src/app/share/note-rename/note-rename.component',
NOTE_TOC:'src/app/share/note-toc/note-toc.component',
PAGE_HEADER:'src/app/share/page-header/page-header.component',
RESIZE_HANDLE:'src/app/share/resize-handle/resize-handle.component',
SHORTCUT:'src/app/share/shortcut/shortcut.component',
SPIN:'src/app/share/spin/spin.component',
THEME_TOGGLE:'src/app/share/theme-toggle/theme-toggle.component'
What type of PR is it?
Improvement
Please leave your type of PR only
Todos
What is the Jira issue?
ZEPPELIN-6373
How should this be tested?
Screenshots (if appropriate)
Questions: