Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

HADOOP-19502. Add RegexpSingleline module to checkstyle.xml.#7535

Closed

Conversation

hfutatzhanghb
Copy link
Contributor

@hfutatzhanghbhfutatzhanghb commentedMar 25, 2025
edited
Loading

Description of PR

Refer to#7505
This pr fix the bug of the original version.
The property of severity does not havewarn value, we should usewarning instead.

How was this patch tested?

image

@hfutatzhanghb
Copy link
ContributorAuthor

@slfan1989 , have fixed the bug, please help review this pr when you have free time, thank you very much!

@hadoop-yetus
Copy link

💔-1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec13m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚mvninstall34m 58strunk passed
+1 💚compile0m 24strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 35strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚mvnsite0m 24strunk passed
+1 💚javadoc0m 31strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 34strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚shadedclient70m 49sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 26sthe patch passed
+1 💚compile0m 14sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac0m 14sthe patch passed
+1 💚compile0m 24sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 24sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚mvnsite0m 14sthe patch passed
+1 💚javadoc0m 15sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 25sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚shadedclient35m 1spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit0m 30shadoop-build-tools in the patch passed.
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
123m 17s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7535/1/artifact/out/Dockerfile
GITHUB PR#7535
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
unameLinux 2f84e2e91778 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /0927728
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7535/1/testReport/
Max. process+thread count702 (vs. ulimit of 5500)
modulesC: hadoop-build-tools U: hadoop-build-tools
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7535/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

@pan3793 Could you please review this change? Thank you very much!

@pan3793
Copy link
Member

@hfutatzhanghb Words like "fix the bug" make no sense, please explain the "why" of the change instead of "what" is the change.

@hfutatzhanghb
Copy link
ContributorAuthor

Hi,@pan3793 . Thanks for reminding. Have updated in the description of this PR. Please see again~

@pan3793
Copy link
Member

@hfutatzhanghb I do not get your point about why a new rule "RegexpSingleline" is required, what is the issue in the current trunk do you want to fix?

@hfutatzhanghb
Copy link
ContributorAuthor

@hfutatzhanghb I do not get your point about why a new rule "RegexpSingleline" is required, what is the issue in the current trunk do you want to fix?

@pan3793 As described in#7505 . In my local, checkstyle tools use trunk's checkstyle.xml can not detect blanks.

@hfutatzhanghb
Copy link
ContributorAuthor

@pan3793 Here is a screenshot, which can detail the problem.
image

@pan3793
Copy link
Member

So this change intends to add a new checkstyle rule to forbid trailing spaces of lines, this generally is a good idea, but after I apply it (I change the severity to error to get the report) and check the current code base, there are more than 40k places that violate this rule

    <module name="RegexpSingleline">        <property name="format" value="\s+$"/>        <property name="severity" value="error"/>    </module>
mvn checkstyle:check | grep RegexpSingleline | wc -l   41890

If we add this rule, fixing those warnings will consume much time and introduce unnecessary commit history, but without real benefits.

Given such a situation, I suggest NOT adding such a rule, and just keeping things as-is.

@hfutatzhanghb
Copy link
ContributorAuthor

@pan3793 Thanks for suggestioning. I got your concerns. Will close this PR.
Thanks@slfan1989 for helping.

@hfutatzhanghbhfutatzhanghb deleted the HADOOP-19502-bugfix branchMarch 27, 2025 07:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hfutatzhanghb@hadoop-yetus@slfan1989@pan3793

[8]ページ先頭

©2009-2025 Movatter.jp