Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

HADOOP-19502. Add RegexpSingleline module to checkstyle.xml.#7505

Merged
slfan1989 merged 1 commit intoapache:trunkfromhfutatzhanghb:HADOOP-19502
Mar 25, 2025

Conversation

hfutatzhanghb
Copy link
Contributor

@hfutatzhanghbhfutatzhanghb commentedMar 14, 2025•
edited by slfan1989
Loading

Description of PR

JIRA:HADOOP-19502. Add RegexpSingleline module to checkstyle.xml.

Add RegexpSingleline module to checkstyle.xml.
In my local, checkstyle tools use checkstyle.xml can not detect blanks.

@hadoop-yetus
Copy link

💔-1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚mvninstall36m 5strunk passed
+1 💚compile0m 24strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 24strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚mvnsite0m 24strunk passed
+1 💚javadoc0m 33strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 24strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚shadedclient71m 24sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 16sthe patch passed
+1 💚compile0m 14sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac0m 14sthe patch passed
+1 💚compile0m 14sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 14sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚mvnsite0m 14sthe patch passed
+1 💚javadoc0m 14sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 15sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚shadedclient34m 26spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit0m 19shadoop-build-tools in the patch passed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
109m 44s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7505/1/artifact/out/Dockerfile
GITHUB PR#7505
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
unameLinux 243e431c62db 5.15.0-134-generic#145-Ubuntu SMP Wed Feb 12 20:08:39 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /91ab935
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7505/1/testReport/
Max. process+thread count623 (vs. ulimit of 5500)
modulesC: hadoop-build-tools U: hadoop-build-tools
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7505/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hfutatzhanghb
Copy link
ContributorAuthor

Hi,@slfan1989 . Could you please help review this PR when have free time? Thanks ahead!

@slfan1989
Copy link
Contributor

@hfutatzhanghb Thanks for the contribution! LGTM.

@slfan1989
Copy link
Contributor

@steveloughran Could you please review this pr? Thank you very much!

@slfan1989
Copy link
Contributor

@hfutatzhanghb If there are no other comments, I will merge this pr tomorrow.

@hfutatzhanghb
Copy link
ContributorAuthor

@hfutatzhanghb If there are no other comments, I will merge this pr tomorrow.

@slfan1989 Thanks a lot!!!

@slfan1989slfan1989 merged commit488376c intoapache:trunkMar 25, 2025
1 of 3 checks passed
@slfan1989
Copy link
Contributor

@hfutatzhanghb Thanks for the contribution!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slfan1989slfan1989slfan1989 approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hfutatzhanghb@hadoop-yetus@slfan1989
[8]ページ先頭
©2009-2025 Movatter.jp