Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixes some otel and nested burr application bugs#590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
skrawcz wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromstefan/fix_nested_otel

Conversation

@skrawcz
Copy link
Contributor

This was caught trying to run nested burr with otel.

Changes

  • otel and application with respect to keys

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Anychange in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This was caught trying to run nested burr with otel.
@github-actions
Copy link

github-actionsbot commentedOct 23, 2025•
edited
Loading

A preview of is uploaded and can be seen here:

✨https://burr.dagworks.io/pull/590 ✨

Changes may take a few minutes to propagate. Since this is a preview of production, content withdraft: true will not be rendered. The source is here:https://github.com/apache/burr/tree/gh-pages/pull/590/

This is a regression test for a bug where state.keys() could return a list
instead of a set, causing a TypeError when trying to do set subtraction.
"""
fromburr.core.applicationimport_validate_reducer_writes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Inline import?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ugh... slop


deftest_burr_tracking_span_processor_on_end_with_none_tracker():
"""Test that on_end handles None tracker gracefully without raising an error."""
processor=BurrTrackingSpanProcessor()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are we sure we need all this mocking? IIRC I wrote this to be easier to unit test...

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

pointer?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@elijahbenizzyelijahbenizzyelijahbenizzy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skrawcz@elijahbenizzy
[8]ページ先頭
©2009-2025 Movatter.jp