Commit8e4897d

committed

code review, use ANVIL_HOSTS everywhere

1 parent2d05029 commit8e4897dCopy full SHA for 8e4897d

File tree

+15

-10

lines changed

+15

-10

lines changed

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,8 @@`
`2`	`2`
`3`	`3`	`frompython_anvil.httpimportHTTPClient`
`4`	`4`
	`5`	`+fromconstantsimportVALID_HOSTS`
	`6`	`+`
`5`	`7`
`6`	`8`	`classAnvilRequest:`
`7`	`9`	`show_headers=False`
`@@ -166,18 +168,13 @@ def get_url(self):`
`166`	`168`	`classFullyQualifiedRequest(BaseAnvilHttpRequest):`
`167`	`169`	`"""A request class that validates URLs point to Anvil domains."""`
`168`	`170`
`169`		`-VALID_HOSTS= [`
`170`		`-"https://app.useanvil.com",`
`171`		`-# Future Anvil specific URLs`
`172`		`- ]`
`173`		`-`
`174`	`171`	`defget_url(self):`
`175`	`172`	`return""# Not used since we expect full URLs`
`176`	`173`
`177`	`174`	`def_validate_url(self,url):`
`178`		`-ifnotany(url.startswith(host)forhostinself.VALID_HOSTS):`
	`175`	`+ifnotany(url.startswith(host)forhostinVALID_HOSTS):`
`179`	`176`	`raiseValueError(`
`180`		`-f"URL must start with one of:{', '.join(self.VALID_HOSTS)}"`
	`177`	`+f"URL must start with one of:{', '.join(VALID_HOSTS)}"`
`181`	`178`	`)`
`182`	`179`
`183`	`180`	`defget(self,url,params=None,**kwargs):`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,14 @@`
`1`	`1`	`"""Basic constants used in the library."""`
`2`	`2`
`3`	`3`	`GRAPHQL_ENDPOINT:str="https://graphql.useanvil.com"`
`4`		`-REST_ENDPOINT="https://app.useanvil.com/api/v1/"`
	`4`	`+REST_ENDPOINT="https://app.useanvil.com/api/v1"`
	`5`	`+ANVIL_HOST="https://app.useanvil.com"`
	`6`	`+`
	`7`	`+VALID_HOSTS= [`
	`8`	`+ANVIL_HOST,`
	`9`	`+REST_ENDPOINT,`
	`10`	`+GRAPHQL_ENDPOINT,`
	`11`	`+]`
`5`	`12`
`6`	`13`	`RETRIES_LIMIT=5`
`7`	`14`	`REQUESTS_LIMIT= {`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`
`13`	`13`	`from ..api_resources.payloadimportFillPDFPayload`
`14`	`14`	`from .importpayloads`
	`15`	`+fromconstantsimportVALID_HOSTS`
`15`	`16`
`16`	`17`
`17`	`18`	`DEV_KEY="MY-SECRET-KEY"`
`@@ -403,7 +404,7 @@ def describe_rest_request_absolute_url_behavior():`
`403`	`404`	`[`
`404`	`405`	`("some/relative/path",True),`
`405`	`406`	`("https://external.example.com/full/path/file.pdf",True),`
`406`		`-("https://app.useanvil.com/api/v1/some-endpoint",False),`
	`407`	`+*[(host+"/some-endpoint",False)forhostinVALID_HOSTS],`
`407`	`408`	`],`
`408`	`409`	`)`
`409`	`410`	`@mock.patch("python_anvil.api_resources.requests.AnvilRequest._request")`
`@@ -431,7 +432,7 @@ def test_get_behavior(mock_request, anvil, url, should_raise):`
`431`	`432`	`[`
`432`	`433`	`("some/relative/path",True),`
`433`	`434`	`("https://external.example.com/full/path/file.pdf",True),`
`434`		`-("https://app.useanvil.com/api/v1/some-endpoint",False),`
	`435`	`+*[(host+"/some-endpoint",False)forhostinVALID_HOSTS],`
`435`	`436`	`],`
`436`	`437`	`)`
`437`	`438`	`@mock.patch("python_anvil.api_resources.requests.AnvilRequest._request")`

Comments

(0)