NotificationsYou must be signed in to change notification settings
Fork1
Star1

Run sync server in a fiber#8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

kpicaza wants to merge1 commit into1.x.x

base:1.x.x

Choose a base branch

fromfix-sync-runner

Open

Run sync server in a fiber#8

kpicaza wants to merge1 commit into1.x.xfromfix-sync-runner

Conversation

Copy link

Member

kpicaza commentedDec 16, 2021

Description

Running await makes the current sync server fail with a segmentation fault because the fiber isn't already started.

Motivation and context

It fixes the described situation and adds real support to use async APIs inside the sync server.

How has this been tested?

Covered by unit tests and tested manually

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put anx in all the boxes that apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have read theCONTRIBUTING document.
My pull request addresses exactly one patch/feature.
I have created a branch for this patch/feature.
Each individual commit in the pull request is meaningful.
I have added tests to cover my changes.
If my change requires a change to the documentation, I have updated it accordingly.

Run sync server in a fiber

52db516

kpicaza added the bugSomething isn't working label

Dec 16, 2021

kpicaza requested review frompeter279k andxserrat

December 16, 2021 21:11

Copy link

codecov-commenter commentedDec 16, 2021

Codecov Report

Merging#8 (52db516) into1.x.x (a14d115) willnot change coverage.
The diff coverage is100.00%.

@@            Coverage Diff            @@##              1.x.x       #8   +/-   ##=========================================  Coverage     80.00%   80.00%             Complexity       12       12           =========================================  Files             5        5             Lines            40       40           =========================================  Hits             32       32             Misses            8        8

Impacted Files	Coverage Δ
src/SyncRunner.php	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea14d115...52db516. Read thecomment docs.