Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(Picker PickerView DatePicker): unified provision of custom prefixCls#6978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
EmilyyyLiu wants to merge5 commits intoant-design:feature
base:feature
Choose a base branch
Loading
fromEmilyyyLiu:feature-picker-prefix

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue#6960

@dosubotdosubotbot added the size:LThis PR changes 100-499 lines, ignoring generated files. labelOct 24, 2025
@coderabbitai
Copy link

coderabbitaibot commentedOct 24, 2025•
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actionsbot commentedOct 24, 2025•
edited
Loading

Preview is ready

@gemini-code-assist
Copy link

Summary of Changes

Hello@EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在为Picker 和PickerView 组件提供统一的自定义类名前缀功能。通过引入prefixCls 属性并与ConfigProvider 集成，开发者可以更灵活地控制这些组件的 CSS 类名，从而更好地适应不同的设计系统和主题。此更改提高了组件的可定制性，并确保了类名生成的一致性，尽管PickerView 组件在实现上存在一些细节问题。

Highlights

  • Picker 组件支持自定义prefixCls: Picker 组件现在可以通过prefixCls 属性或ConfigProvider 配置自定义类名前缀，增强了组件的可定制性。
  • PickerView 组件支持自定义prefixCls 属性: PickerView 组件的类型定义中增加了prefixCls 属性，允许其接收自定义类名前缀（主要由 Picker 组件传递）。
  • 更新类名引用: Picker 和 PickerView 组件内部的 DOM 元素类名引用已更新，以使用动态生成的或局部定义的prefixCls 变量。
  • 新增测试用例: 增加了新的测试用例，以验证 Picker 和 PickerView 在 ConfigProvider 和组件自身prefixCls 属性下的类名行为是否符合预期。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

@dosubotdosubotbot added the feature labelOct 24, 2025
@pkg-pr-new
Copy link

pkg-pr-newbot commentedOct 24, 2025•
edited
Loading

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6978

commit:171bc7b

Copy link

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

本次 PR 旨在统一Picker 和PickerView 组件对自定义prefixCls 的处理。Picker 组件和相关测试的改动是正确的，但PickerView 组件的实现似乎未完成。其中的prefixCls 被硬编码，违背了本次改动的初衷。另外，loadingContent 的默认className 也有误，并且同样是硬编码的。我已在代码中提出了具体的修改建议。

@codecov
Copy link

codecovbot commentedOct 24, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (bfde19d) to head (171bc7b).

Additional details and impacted files
@@           Coverage Diff            @@##           feature    #6978   +/-   ##========================================  Coverage    92.95%   92.96%           ========================================  Files          337      337             Lines         7368     7376    +8       Branches      1871     1872    +1     ========================================+ Hits          6849     6857    +8  Misses         483      483             Partials        36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyyyLiuEmilyyyLiu changed the titlefeat(Picker PickerView): unified provision of custom prefixClsfeat(Picker PickerView DatePicker): unified provision of custom prefixClsOct 24, 2025
EmilyyyLiuand others added2 commitsOctober 24, 2025 12:01
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

featuresize:LThis PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EmilyyyLiu
[8]ページ先頭
©2009-2025 Movatter.jp