- Notifications
You must be signed in to change notification settings - Fork2.5k
feat(AutoCenter): unified provision of custom prefixCls#6963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:feature
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actionsbot commentedOct 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Summary of ChangesHello@EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a unified mechanism for managing and customizing CSS class prefixes throughout the component library. By integrating a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
pkg-pr-newbot commentedOct 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
commit: |
codecovbot commentedOct 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## feature #6963 +/- ##======================================== Coverage 92.95% 92.95% ======================================== Files 337 337 Lines 7368 7370 +2 Branches 1871 1861 -10 ========================================+ Hits 6849 6851 +2 Misses 483 483 Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
此 PR 统一了为组件提供自定义prefixCls 的方式,通过在ConfigProvider 中引入getPrefixCls 函数来实现。这是一个很好的改进,可以提高组件库的灵活性和可定制性。
代码实现方面,AutoCenter 组件已正确适配了新的prefixCls 机制。
我发现ConfigProvider 的实现中存在一个性能问题:传递给上下文(Context)的value 对象没有被记忆化(memoized),这可能导致不必要的组件重渲染。我已在相关代码处提出了具体的反馈和优化建议。
除此之外,其他部分的修改(包括文档和测试)看起来都很不错。
434f27c to015185bCompare
统一添加自定义class 前缀
关联issue#6960