Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(AutoCenter): unified provision of custom prefixCls#6963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
EmilyyyLiu wants to merge1 commit intoant-design:feature
base:feature
Choose a base branch
Loading
fromEmilyyyLiu:feature-auto-center

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue#6960

@dosubotdosubotbot added the size:MThis PR changes 30-99 lines, ignoring generated files. labelOct 21, 2025
@coderabbitai
Copy link

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actionsbot commentedOct 21, 2025
edited
Loading

Preview failed

@gemini-code-assist
Copy link

Summary of Changes

Hello@EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a unified mechanism for managing and customizing CSS class prefixes throughout the component library. By integrating agetPrefixCls function into theConfigProvider, components can now consistently derive their class names, supporting both global and individual component-level prefix overrides. This enhancement significantly improves the flexibility of styling and ensures a cohesive approach to class naming conventions across the library, with theAutoCenter component serving as an initial adopter of this new pattern.

Highlights

  • Centralized Class Prefix Management: Introduced agetPrefixCls utility function within theConfigProvider to standardize how CSS class prefixes are generated across components, ensuring consistency and flexibility.
  • Customizable Prefixes: Components can now receive an optionalprefixCls prop, allowing for individual component-level customization that overrides the globalprefixCls set inConfigProvider.
  • AutoCenter Component Integration: TheAutoCenter component has been refactored to utilize the newgetPrefixCls utility, demonstrating the new pattern for dynamic class prefixing.
  • Documentation and Testing Updates: Updated both English and Chinese documentation forConfigProvider to include the newprefixCls prop, and adjusted test cases to reflect the addition ofgetPrefixCls to theuseConfig hook's return value.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.

@dosubotdosubotbot added the feature labelOct 21, 2025
@pkg-pr-new
Copy link

pkg-pr-newbot commentedOct 21, 2025
edited
Loading

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6963

commit:015185b

@codecov
Copy link

codecovbot commentedOct 21, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (bfde19d) to head (015185b).

Additional details and impacted files
@@           Coverage Diff            @@##           feature    #6963   +/-   ##========================================  Coverage    92.95%   92.95%           ========================================  Files          337      337             Lines         7368     7370    +2       Branches      1871     1861   -10     ========================================+ Hits          6849     6851    +2  Misses         483      483             Partials        36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

此 PR 统一了为组件提供自定义prefixCls 的方式,通过在ConfigProvider 中引入getPrefixCls 函数来实现。这是一个很好的改进,可以提高组件库的灵活性和可定制性。

代码实现方面,AutoCenter 组件已正确适配了新的prefixCls 机制。

我发现ConfigProvider 的实现中存在一个性能问题:传递给上下文(Context)的value 对象没有被记忆化(memoized),这可能导致不必要的组件重渲染。我已在相关代码处提出了具体的反馈和优化建议。

除此之外,其他部分的修改(包括文档和测试)看起来都很不错。

@dosubotdosubotbot added size:SThis PR changes 10-29 lines, ignoring generated files. and removed size:MThis PR changes 30-99 lines, ignoring generated files. labelsOct 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

featuresize:SThis PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EmilyyyLiu

[8]ページ先頭

©2009-2025 Movatter.jp