- Notifications
You must be signed in to change notification settings - Fork1.2k
feature(login) keep session living#444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
remicastaing wants to merge6 commits intoangular-fullstack:canaryChoose a base branch
base:canary
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+99 −40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@DaftMonk, I understand why you said it didn't work for you. I didn't checked if my PR works for FB, G+ or Tw. I have found my mistake: |
…he admin pageChanges:- use User.query() in admin.controller instead of $http
…ing uibootstrapChanges: (only if ui-bootstrap is selected)- add `client/components/modal` folder- modal folder contains service, markup template, and stylesheet- modal service is intended to be extended, comes with `Modal.confirm.delete()` method- admin and main page will both use `Modal.confirm.delete()`Todo:- review code for cleanliness and correctness- possibly extend the modal service to include a basic alert class?- write test for `Modal` service?
Changes:- Update jshint task in `Gruntfile.js` to include `serverTest`- Add `server/.jshintrc-spec` that extends `server/.jshintrc` with spec globals- Use `"latedef": "nofunc"` instead of `"latedef": true` in `server/.jshintrc`- Add assertion for `jshint` task in generator tests for `defaultOptions`- Fix pre exsisting lint errors in `server` and `client`- Change `getEmail()` in `client/app/account/settings/settings.controller` to use `user` arg and not `$scope.user`Closes#463,#486
This reverts commitef06272.Conflicts:app/templates/client/app/account(auth)/settings/settings.controller(coffee).coffeeapp/templates/client/app/account(auth)/settings/settings.controller(js).jsapp/templates/client/app/admin(auth)/admin(html).htmlapp/templates/client/app/admin(auth)/admin(jade).jadeapp/templates/client/app/admin(auth)/admin.controller(coffee).coffeeapp/templates/client/app/admin(auth)/admin.controller(js).jsapp/templates/server/api/user(auth)/user.controller.jsapp/templates/server/api/user(auth)/user.model.jsapp/templates/server/auth(auth)/facebook(facebookAuth)/index.jsapp/templates/server/auth(auth)/facebook(facebookAuth)/passport.jsapp/templates/server/auth(auth)/google(googleAuth)/index.jsapp/templates/server/auth(auth)/google(googleAuth)/passport.jsapp/templates/server/config/_local.env.jsapp/templates/server/config/environment/index.js
Now, tests are passing and localStorage works for local, FB, G+ and Tw. |
Session token is valid for 30 days and will be stored in browser's local storage until user log out.- replace ngCookie by ngStorage- replace $cookie by $localStorage- add token duration parameter in config file- add role in signToken
Closed
Climax777 commentedFeb 8, 2017
When can we expect this to be merged? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session token is valid for 30 days and will be stored in browser's local storage until user logs out.