Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(schematics): rewriteprojectFromRc and add spec file#3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
nontangent wants to merge3 commits intoangular:main
base:main
Choose a base branch
Loading
fromnontangent:fix/project-from-rc-bug

Conversation

@nontangent
Copy link

@nontangentnontangent commentedNov 4, 2022•
edited
Loading

Checklist

Description

Fix#3077 and add unit tests.

Code sample

No API changes.

asithade and kingpeti reacted with thumbs up emoji
@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nontangentnontangent marked this pull request as ready for reviewNovember 4, 2022 06:04
@nontangent
Copy link
Author

I've just signed CLA.

@davideastdavideast self-requested a reviewJune 23, 2023 15:10
@davideastdavideast self-assigned thisJun 23, 2023
Copy link
Collaborator

@davideastdavideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nontangent Thank you so much for this contribution and I apologize for how late it took us to get to it. I'll need to test through one a bit thoroughly myself so hang tight.

nontangent reacted with thumbs up emoji
@arlopezg
Copy link

I think this would fix#3309

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@davideastdavideastdavideast approved these changes

Assignees

@davideastdavideast

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code in schematics/deploy/builder.ts is preventing the usage of any non-default firebaseProject and firebaseHostingSite values

3 participants

@nontangent@arlopezg@davideast
[8]ページ先頭
©2009-2025 Movatter.jp