Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updating callable functions documentation#3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tdkehoe wants to merge1 commit intoangular:main
base:main
Choose a base branch
Loading
fromtdkehoe:patch-2

Conversation

@tdkehoe
Copy link

Inapp.module.ts I put in commented out lines anticipating AngularFire 7. When AngularFire 7 is available for callable functions we can easily update the documentation with a few clicks.

I also put in two lines showing how to run your functions in the Firebase emulator. I clearly indicated how to comment out these lines to run your functions in the cloud.

I made an HTML view to show how to handle user input. Also I added a second set of curly brackets to{{ data$ | async }}. This is necessary to make the code run without throwing errors.

Inapp.component.ts I put in lines anticipating AngularFire 7.

I moved the template to an HTML view.

I added a variabledata$ to handle the data returned from the cloud function. I addedthis tofns.httpsCallable('my-fn-name');. These changes are necessary to make the code run without throwing errors.

I changedfns tofunctions for readability.

I made two functions, one that executes on page load and the user executes on user input.

I put in theindex.js file showing the cloud functions. The old documentation was confusing as to what data went from Angular to the cloud function and what data was returned from the cloud function. Showing theindex.js functions clarifies this.

I've written a longer tutorial athttps://github.com/tdkehoe/Firebase-Cloud-Functions-with-Angular/blob/main/README.md.

When can we expect to use AngularFire 7 with callable functions?

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes)
  • Test units included?: (no)
  • In a clean directory,yarn install,yarn test run successfully? (no)

Description

Updating the documentation for callable functions. The existing documentation has a few problems:

  • A few syntax errors in the component controller throw errors.
  • Doesn't show how to use the Firebase emulator.
  • Doesn't show how to call a function from user input, e.g., clicking a button in the view.
  • Is confusing about what data is sent from Angular to the cloud function and what data is returned from the cloud function to Angular.
  • Doesn't show how to use AngularFire 7.

In `app.module.ts` I put in commented out lines anticipating AngularFire 7. When AngularFire 7 is available for callable functions we can easily update the documentation with a few clicks.I also put in two lines showing how to run your functions in the Firebase emulator. I clearly indicated how to comment out these lines to run your functions in the cloud.I made an HTML view to show how to handle user input. Also I added a second set of curly brackets to `{{ data$ | async }}`. This is necessary to make the code run without throwing errors.In `app.component.ts` I put in lines anticipating AngularFire 7.I moved the template to an HTML view. I added a variable `data$` to handle the data returned from the cloud function. I added `this` to `fns.httpsCallable('my-fn-name');`. These changes are necessary to make the code run without throwing errors.I changed `fns` to `functions` for readability.I made two functions, one that executes on page load and the user executes on user input.I put in the `index.js` file showing the cloud functions. The old documentation was confusing as to what data went from Angular to the cloud function and what data was returned from the cloud function. Showing the `index.js` functions clarifies this.I've written a longer tutorial athttps://github.com/tdkehoe/Firebase-Cloud-Functions-with-Angular/blob/main/README.md.When can we expect to use AngularFire 7 with callable functions?
@davideastdavideast self-requested a reviewJune 23, 2023 15:16
@davideastdavideast self-assigned thisJun 23, 2023
@davideastdavideastenabled auto-merge (squash)June 23, 2023 15:21
Copy link
Collaborator

@davideastdavideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@tdkehoe Thank you so much! Apologies on the (very) late review. I'm working to get the conflicts resolved as well.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@davideastdavideastdavideast approved these changes

Assignees

@davideastdavideast

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tdkehoe@davideast

[8]ページ先頭

©2009-2025 Movatter.jp