NotificationsYou must be signed in to change notification settings
Fork2.2k
Star7.8k

Commiteb99d8e

authored

fix: Avoid handling promise rejections twice in stability helper (#3657)

`PendingTasks.run` reports rejections of the promise to the`ErrorHandler`. This function already returns a promise that is meant tobe handled in the developer's application. If there _is_ handling there,the rejection is handled both in the `PendingTasks.run` and in thedeveloper callsite.This change updates the code to use `PendingTasks.add` instead, whichhas no built in error handling mechanisms.fixesangular/angular#61932

1 parentc1c6af9 commiteb99d8eCopy full SHA for eb99d8e

File tree

1 file changed

-2

lines changed

src
- zones.ts

1 file changed

-2

lines changed

`‎src/zones.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -170,12 +170,12 @@ export const ɵzoneWrap = <T= unknown>(it: T, blockUntilFirst: boolean, logLevel`
`170`	`170`	`// eslint-disable-next-line @typescript-eslint/no-misused-promises`
`171`	`171`	`returnrun(`
`172`	`172`	`()=>{`
`173`		`-pendingTasks.run(()=>ret);`
	`173`	`+constremoveTask=pendingTasks.add();`
`174`	`174`	`returnnewPromise((resolve,reject)=>{`
`175`	`175`	`ret.then(`
`176`	`176`	`(it)=>runInInjectionContext(injector,()=>run(()=>resolve(it))),`
`177`	`177`	`(reason)=>runInInjectionContext(injector,()=>run(()=>reject(reason)))`
`178`		`-)`
	`178`	`+).finally(removeTask);`
`179`	`179`	`});`
`180`	`180`	`});`
`181`	`181`	`}elseif(typeofret==='function'&&taskDone){`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commiteb99d8e

File tree

1 file changed

1 file changed

`‎src/zones.ts‎`

0 commit comments