- Notifications
You must be signed in to change notification settings - Fork27k
docs: update localization docs and modernize examples#66184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
SkyZeroZx wants to merge1 commit intoangular:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+7 −20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| private_viewContainerRef=inject(ViewContainerRef); | ||
| @ViewChild(TemplateRef)_dialogTemplate!:TemplateRef<any>; | ||
| _dialogTemplate=viewChild.required(TemplateRef); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: Could you also make it private, it's unused in the template (and also that was hinted by the leading underscore.
Suggested change
| _dialogTemplate=viewChild.required(TemplateRef); | |
| private_dialogTemplate=viewChild.required(TemplateRef); |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done
Improves the localization documentation by updating code highlight syntax issuesand removing outdated TODOs.Additionally, the CDK examples have been updated to use the viewChild query signal API,aligning the docs with current recommended patterns.
fd8fe01 to62d7b1cCompareJeanMeche approved these changesDec 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
action: mergeThe PR is ready for merge by the caretaker area: docsRelated to the documentation target: patchThis PR is targeted for the next patch release
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Improves the localization documentation by updating code highlight syntax issues and removing outdated TODOs.
Additionally, the CDK examples have been updated to use the viewChild query signal API, aligning the docs with current recommended patterns.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information