- Notifications
You must be signed in to change notification settings - Fork38
Support STI and inheritance(with test)#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
unasuke wants to merge3 commits intoamatsuda:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@raskhadafi@unasuke Nice, but what's gonna happen if we created multiple STI child classes, and then declared enums on each of these? e.g. classBug <ActiveRecord::Baseself.abstract_class=trueendclassNormalBug <Bugenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3}do ...endendclassCriticalBug <Bugenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3,released:4}do ...endend So, maybe we can fallback to Moreover, there can be enums with the same name on BOTH parent and children classes, and I'm not sure what's the desired behavior in such case. |
I confirmed the current behavior of stateful_enum and it seems good for me. How do you think@amatsuda ? Is it test cases lack some edge-case? and...@raskhadafi, do you think about this? classBug <ActiveRecord::Baseenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3}doevent:assigndotransition:unassigned=>:assignedendendendclassNormalBug <Bugenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3}doevent:assigndotransition:closed=>:assignedendevent:resolvedotransition[:unassigned,:assigned]=>:resolvedendendendclassCriticalBug <Bugenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3,released:4}doevent:assigndotransition:closed=>:assignedendevent:releasedotransition:resolved=>:releasedendendendclassBugTest <Minitest::Testdeftest_bug_cannnot_resolvebug=Bug.create!(status::unassigned)assert_raises(NoMethodError)dobug.resolveendenddeftest_normal_bug_can_resolvenormal_bug=NormalBug.create!(status::unassigned)normal_bug.resolveassert_equal'resolved',normal_bug.statusenddeftest_unassigned_critical_big_cannot_assigncritical_bug=CriticalBug.create!(status::unassigned)critical_bug.assignassert_equal'unassigned',critical_bug.statusendend sample code(full)# frozen_string_literal: truebeginrequire"bundler/inline"rescueLoadError=>e $stderr.puts"Bundler version 1.10 or later is required. Please update your Bundler"raiseeendgemfile(true)dosource"https://rubygems.org"git_source(:github){ |repo|"https://github.com/#{repo}.git"}#gem "rails", github: "rails/rails"gem"rails",'5.2.0'gem"sqlite3"gem'stateful_enum',git:'https://github.com/unasuke/stateful_enum.git',ref:'6f6e18b1d'endrequire"active_record"require"minitest/autorun"require"logger"# This connection will do for database-independent bug reports.ActiveRecord::Base.establish_connection(adapter:"sqlite3",database:":memory:")ActiveRecord::Base.logger=Logger.new(STDOUT)ActiveRecord::Schema.definedocreate_table:bugs,force:truedo |t|t.integer:statust.string:typeendendclassBug <ActiveRecord::Baseenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3}doevent:assigndotransition:unassigned=>:assignedendendendclassNormalBug <Bugenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3}doevent:assigndotransition:closed=>:assignedendevent:resolvedotransition[:unassigned,:assigned]=>:resolvedendendendclassCriticalBug <Bugenumstatus:{unassigned:0,assigned:1,resolved:2,closed:3,released:4}doevent:assigndotransition:closed=>:assignedendevent:releasedotransition:resolved=>:releasedendendendclassBugTest <Minitest::Testdeftest_bug_cannnot_resolvebug=Bug.create!(status::unassigned)assert_raises(NoMethodError)dobug.resolveendenddeftest_normal_bug_can_resolvenormal_bug=NormalBug.create!(status::unassigned)normal_bug.resolveassert_equal'resolved',normal_bug.statusenddeftest_unassigned_critical_big_cannot_assigncritical_bug=CriticalBug.create!(status::unassigned)critical_bug.assignassert_equal'unassigned',critical_bug.statusendend |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dups#29 .But I wrote test.
Original pull request description is below.
If use stateful_enum on STI model, raise that error.