Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

AddInvalidTransition exception with more helpful message.#30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ordinaryzelig wants to merge1 commit intoamatsuda:master
base:master
Choose a base branch
Loading
fromordinaryzelig:master

Conversation

@ordinaryzelig
Copy link

I thought it would be nice to see and have access to a bit more information when the transition is invalid. This changes theRuntimeError to a customStatefulEnum::InvalidTransition exception. The error message contains the state and the event that was attempted. Those 2 pieces of information are also stored on the exception itself for easy access.

I almost took it a step further by adding what the state would have been if the event had succeeded – e.g. in the test below:Invalid transition from "resolved" to "assigned" via event :assign!' – but that would take significantly more work. I believe the solution to that would require storing the events in memory. I'm not even sure how useful it would be to know that information. But if you like the idea, I would be happy to continue to explore the idea.

yuemori, uplus, mohamed-karam, rypark, ugisozols, andrepinho, myabc, adilw3nomad, and gmanninglive reacted with thumbs up emoji
@uplusuplus mentioned this pull requestJan 14, 2019
@andrepinho
Copy link

andrepinho commentedAug 5, 2020
edited
Loading

This is great! It seems to solves the only task in theTODO section.

I'm currently rescuing from RuntimeError with minimal details about what's going on and this would be very helpful.

I wonder why it has not been merged yet. Does this implementation need some work? Is it just a matter of resolving conflicts? I would love to contribute but I'm not sure how.

@ordinaryzelig
Copy link
Author

I would love to contribute but I'm not sure how.

You could start with resolving the conflicts and making sure the tests still pass. 😄

andrepinho reacted with thumbs up emoji

@ordinaryzelig
Copy link
Author

Updated to v0.7.0. Resolved conflicts.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ordinaryzelig@andrepinho

[8]ページ先頭

©2009-2025 Movatter.jp