Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
LEX fix#1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
LEX fix#1187
Uh oh!
There was an error while loading.Please reload this page.
Conversation
amark commentedFeb 3, 2022
@orimay wow! You're one of the few people who has been able to SUBTRACT lines of code. That's like gold star 🌟 status right there. I'm very impressed, I need to find time this/next week now that I'm back to do a call with you, hopefully I'll run some other checks/tests before then too, but... I'm bad at overpromising. I'm very excited about this. |
amark commentedFeb 19, 2022
No rush, like we talked, still looking to merge this after the couple tweaks. No rush tho, I appreciate the help. |
amark commentedFeb 19, 2022
Oh oops! I should have looked at your other PR before commenting here. Now I feel stupid/dumb. So sorry. IDK why but GitHub not update me, so please ping me! (which... I know I have a telegram message, so you probably did, so I need to log onto telegram to check that too. Sorry I'm so bad/slow!) |
orimay commentedFeb 19, 2022
No worries! |
orimay commentedFeb 19, 2022
I thought I pushed the update.. Will try to look into this as I get access to my laptop |
This way, we take order into account even if we have the wildcard match