Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement RFC 73: Stricter connections.#1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
zyp wants to merge1 commit intoamaranth-lang:main
base:main
Choose a base branch
Loading
fromzyp:rfc_73

Conversation

@zyp
Copy link
Contributor

@zypzyp commentedOct 18, 2025

No description provided.

@codecov
Copy link

codecovbot commentedOct 18, 2025
edited
Loading

Codecov Report

❌ Patch coverage is85.71429% with4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.28%. Comparing base (638edff) to head (b07ee84).

Files with missing linesPatch %Lines
amaranth/lib/enum.py33.33%1 Missing and 1 partial⚠️
amaranth/lib/wiring.py90.90%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #1637      +/-   ##==========================================- Coverage   91.28%   91.28%   -0.01%==========================================  Files          44       44                Lines       11471    11493      +22       Branches     2236     2240       +4     ==========================================+ Hits        10471    10491      +20- Misses        837      839       +2  Partials      163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@whitequarkwhitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs at the very least:

  • Tests for changes in lib.data and lib.enum
  • Changelog update

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@whitequarkwhitequarkwhitequark requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zyp@whitequark

[8]ページ先頭

©2009-2025 Movatter.jp