Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Dynamic Text Color & Stroke Support#2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ciss1995 wants to merge7 commits intoairbnb:master
base:master
Choose a base branch
Loading
fromciss1995:ccisse/enable_custom_color_text_layer

Conversation

@ciss1995
Copy link
Contributor

Summary
This PR adds support for dynamically overriding the Fill Color and Stroke Color of Text Layers using ValueProviders.

Changes

  1. TextCompositionLayer
  • Exposed color ("Color") and strokeColor ("Stroke Color") properties to the KeypathSearchable system.
  • Initialized fillColorNode and strokeColorNode using mapped keyframes, ensuring strokeColorData supports dynamic overrides with a transparent fallback.
  1. TextLayer
  • Added support for static color overrides for "Color" and "Stroke Color".
  • Note: Due to the static nature of CoreTextRenderLayer in the CA engine, only the first keyframe of a value provider is applied.
  1. Shared Constants
  • Added PropertyName.strokeColor case.

@ciss1995ciss1995 deleted the ccisse/enable_custom_color_text_layer branchDecember 16, 2025 23:29
@ciss1995ciss1995 restored the ccisse/enable_custom_color_text_layer branchDecember 16, 2025 23:30
@calda
Copy link
Member

I will not review this change since you closed the PR, but if you have questions or need advice just ask! Thanks for taking a go at it.

ciss1995 reacted with heart emoji

@ciss1995ciss1995 reopened thisDec 17, 2025
@ciss1995ciss1995 changed the titleDynamic Text Color & Stroke Support[WIP] Dynamic Text Color & Stroke SupportDec 17, 2025
@caldacalda marked this pull request as draftDecember 17, 2025 03:17
@ciss1995ciss1995 marked this pull request as ready for reviewDecember 17, 2025 18:53
@ciss1995ciss1995 changed the title[WIP] Dynamic Text Color & Stroke SupportDynamic Text Color & Stroke SupportDec 17, 2025
@ciss1995
Copy link
ContributorAuthor

I will not review this change since you closed the PR, but if you have questions or need advice just ask! Thanks for taking a go at it.

Hi Cal! I am ready for a review :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ciss1995@calda
[8]ページ先頭
©2009-2025 Movatter.jp