NotificationsYou must be signed in to change notification settings
Fork17
Star86

Commit8ff0244

committed

(test): ensure jsonify can be set to false

- previously a bug made it so you couldn't set it to false- this option is an edge case that's mostly useful for certain storage engines like WebSQL, IndexedDB, etc that can actually handle non-string data - for localStorage, objects just get stored as '[object Object]' if they're not jsonified - might want to throw on jsonify = false and localStorage engine?

1 parent1398eae commit8ff0244Copy full SHA for 8ff0244

File tree

1 file changed

+11

-0

lines changed

test
- index.spec.ts

1 file changed

+11

-0

lines changed

`‎test/index.spec.ts‎`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,17 @@ describe('basic persist options', () => {`
`27`	`27`	`expect(getItem('user')).toStrictEqual(getSnapshot(user))`
`28`	`28`	`})`
`29`	`29`
	`30`	`+it('shouldn\'t jsonify',async()=>{`
	`31`	`+constuser=UserStore.create()`
	`32`	`+awaitpersist('user',user,{`
	`33`	`+jsonify:false`
	`34`	`+})`
	`35`	`+`
	`36`	`+user.changeName('Joe')// fire action to trigger onSnapshot`
	`37`	`+// if not jsonified, localStorage will store as '[object Object]'`
	`38`	`+expect(window.localStorage.getItem('user')).toBe('[object Object]')`
	`39`	`+})`
	`40`	`+`
`30`	`41`	`it('should whitelist',async()=>{`
`31`	`42`	`constuser=UserStore.create()`
`32`	`43`	`awaitpersist('user',user,{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit8ff0244

File tree

1 file changed

1 file changed

`‎test/index.spec.ts‎`

0 commit comments