Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix audiocore.RawSample with loop=False on esp32*#10540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
deshipu wants to merge1 commit intoadafruit:main
base:main
Choose a base branch
Loading
frompython-ugame:main

Conversation

@deshipu
Copy link

We only want to exit the playing loop when the sample_data wasn't null, otherwise we need to get the buffer and play it once.

Fix#10539

We only want to exit the playing loop when the sample_data wasn'tnull, otherwise we need to get the buffer and play it once.Fixadafruit#10539
@deshipu
Copy link
Author

This is a bit awkward, but I can't think about a better way of doing it right now. Improvements welcome.

@dhalbert
Copy link
Collaborator

From#10539 (comment)

Even with the above fix, things seem to be pretty broken. There is some random noise at the beginning, and sample rates below about 6000 don't work at all.

I also tried on rp2040, and it will also not play with sample rates below 6000, and will hang when playing a second time.

@dhalbert
Copy link
Collaborator

The failed jobs are due to an upstream problem with esptool which is now fixed. But if it's not working yet, I won't re-run yet.

@dhalbertdhalbert marked this pull request as draftAugust 4, 2025 16:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

audiocore.RawSample doesn't work with loop=False on esp32* boards

2 participants

@deshipu@dhalbert
[8]ページ先頭
©2009-2025 Movatter.jp