Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base(3b54bde) to head(6775587).

@@           Coverage Diff           @@##           master    #8031   +/-   ##=======================================  Coverage   99.11%   99.11%           =======================================  Files         141      141             Lines        4069     4070    +1     =======================================+ Hits         4033     4034    +1  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@javierjulio this LGTM. What do you think?

@mgrunberg not quite. It's why I held off but left this here as I'd like to see it resolved. I'm just not sure what the solution should be. I encountered this too the year before and resolved by callingsuper instead ofindex! inside theindex action I had overridden. The following is the case I ran into:

controller do  def index    params[:some_flag] = "blah"-   index!+   super  endend

This is puzzling because I'm not sure why we are getting a new action method if InheritedResources would be defining this alias anyway since the Base applies the Actions module. Can you check if the controller has protected methods forshow!,create!, etc.? I realized while responding, that this PR is setting a public alias but InheritedResources declares them as protected. Perhaps that would suffice here as I do recall one concern I had was the unexpected assertion change in the resource_controller_spec.rb file.

I'd like to see tests that have a custom index action that does something, e.g. set a param, before callingindex! where a request is made for bothhtml andcsv to confirm it works as expected.

@javierjulio thanks for the feedback. I need some time to think about your comment. I'll come back to this in a few days. I don't discard even copy this PR as an "in repo".