Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.3k
Prioritize filters with predicates in active filter labels (#7702)#7717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Prioritize filters with predicates in active filter labels (#7702)#7717
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ee720aa tod46e559Compare
corlissc left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ray-curran looks good. This will resolve the issue that I submitted.
d46e559 to420bc74Comparecodecovbot commentedMar 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #7717 +/- ##======================================= Coverage 99.05% 99.05% ======================================= Files 184 184 Lines 4740 4740 ======================================= Hits 4695 4695 Misses 45 45
☔ View full report in Codecov by Sentry. |
…in#7702)When there are filters for a single field and a multi-field ransacksearch with predicate, the multi-field label on the active filtershould use the custom label from the filter input box.Reproduction steps:./app/admin/posts.rb```ActiveAdmin.register Post do filter :title_or_body_contains, as: :string, label: 'Title or Body' filter :title, as: :string ...end```Navigate to the posts path for a user like`localhost:3000/admin/users/4/posts`Complete search in both fields, note that both active filters use thelabel "Title contains". The `title_or_body_contains` should use thelabel from the filter "Title or Body contains".
420bc74 to7e29df2Compare
Uh oh!
There was an error while loading.Please reload this page.
When there are filters for a single field and a multi-field ransack search with predicate, the multi-field label on the active filter should use the custom label from the filter input box.
Reproduction steps:
./app/admin/posts.rb
Navigate to the posts path for a user like
localhost:3000/admin/users/4/postsComplete search in all fields, note that all three active filters use the label "Title contains".
The
title_or_body_containsshould use the label from the filter "Title or Body contains".The
title_or_bodyshould use the label from the filter: "Title/Body equals".Fixes#7702