Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.3k
feat: Customize the title in batch action.#6909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
feat: Customize the title in batch action.#6909
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7022e1f toc2f2b53Comparedeivid-rodriguez commentedApr 16, 2021
I don't have a strong opinion but I guess it's fine.@javierjulio? |
javierjulio commentedApr 16, 2021
@deivid-rodriguez I don't see why the i18n option wouldn't suffice for this as I think that would be better but then I tried thinking of what would be similar to this elsewhere in AA and that would probably be filters as a label can be given to override the i18n default. So I think this would be ok. The one thing I'd bring up is considering using |
deivid-rodriguez commentedApr 17, 2021
Yeah, I had the same initial thought ("just use i18n"), but then I thought having to use i18n on monolingual apps to configure these simple things is a bit annoying an somewhat a "feature abuse" so this thing seems simple and could come handy sometimes. Agreed on using |
deivid-rodriguez commentedApr 17, 2021
Although forms seems to already have a |
Sometime i would like to custom the title of batch_action.