Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Customize the title in batch action.#6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lanzhiheng wants to merge1 commit intoactiveadmin:master
base:master
Choose a base branch
Loading
fromlanzhiheng:custom-the-title-of-batch-title

Conversation

@lanzhiheng
Copy link
Contributor

Sometime i would like to custom the title of batch_action.

@lanzhihenglanzhihengforce-pushed thecustom-the-title-of-batch-title branch from7022e1f toc2f2b53CompareApril 15, 2021 13:25
@deivid-rodriguez
Copy link
Member

I don't have a strong opinion but I guess it's fine.@javierjulio?

@javierjulio
Copy link
Member

@deivid-rodriguez I don't see why the i18n option wouldn't suffice for this as I think that would be better but then I tried thinking of what would be similar to this elsewhere in AA and that would probably be filters as a label can be given to override the i18n default. So I think this would be ok. The one thing I'd bring up is considering usinglabel: instead oftitle: for the option name as we use the former mostly and with menu-like components.

@deivid-rodriguez
Copy link
Member

Yeah, I had the same initial thought ("just use i18n"), but then I thought having to use i18n on monolingual apps to configure these simple things is a bit annoying an somewhat a "feature abuse" so this thing seems simple and could come handy sometimes. Agreed on usinglabel to name things consistently 👍.

@deivid-rodriguez
Copy link
Member

Although forms seems to already have atitle option that behaves the same way, so we're already inconsistent, so I guess we should choose the name that makes most sense for batch actions.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lanzhiheng@deivid-rodriguez@javierjulio

[8]ページ先頭

©2009-2025 Movatter.jp