- Notifications
You must be signed in to change notification settings - Fork613
Fix line-endings inpackage.json#623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
matthewhughes934 wants to merge1 commit intoactions:mainChoose a base branch frommatthewhughes934:fix-package-json-line-endings
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix line-endings inpackage.json#623
matthewhughes934 wants to merge1 commit intoactions:mainfrommatthewhughes934:fix-package-json-line-endings
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Because I just spent far too much time trying to figure out why `npminstall` added carriage returns to `package-lock.json` and then `git`would complain:> warning: in the working copy of 'package-lock.json', CRLF will bereplaced by LF the next time Git touches itThis is simply the result of running: git add --renormalize package.jsonSince the attributes on that file set line endings to simply `\n`: $ git check-attr -a package.json package.json: text: auto package.json: eol: lf
8278a8e to2fa5708CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because I just spent far too much time trying to figure out why
npm installadded carriage returns topackage-lock.jsonand thengitwould complain:This is simply the result of running:
Since the attributes on that file set line endings to simply
\n: