Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix golang download url to go.dev#469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
178inaba wants to merge4 commits intoactions:main
base:main
Choose a base branch
Loading
from178inaba:fix-golang-org

Conversation

@178inaba
Copy link
Contributor

@178inaba178inaba commentedApr 5, 2024•
edited
Loading

Description:

golang.org is redirect to go.dev

$ curl -v 'https://golang.org/dl/?mode=json&include=all'...< HTTP/2 301...< location: https://go.dev/dl/?mode=json&include=all...<a href="https://go.dev/dl/?mode=json&amp;include=all">Moved Permanently</a>.

Related issue:

None.

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

Since it's only a change in the URL, it seems that no additions to documentation or testing are necessary.

dmitris reacted with thumbs up emoji
@178inaba178inaba requested a review froma team as acode ownerApril 5, 2024 18:06
@krylov-krylov
Copy link

Description:

golang.org is redirect to go.dev

$ curl -v 'https://golang.org/dl/?mode=json&include=all'...< HTTP/2 301...< location: https://go.dev/dl/?mode=json&include=all...<a href="https://go.dev/dl/?mode=json&amp;include=all">Moved Permanently</a>.

Related issue:

None.

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

Since it's only a change in the URL, it seems that no additions to documentation or testing are necessary.

@dmitris
Copy link

@178inaba - could you resolve the conflicts, please? Hopefully it would help to get this small change finally landed 🙏

@178inaba
Copy link
ContributorAuthor

@dmitris
Thanks for your comment! I've resolved the conflicts via rebase.
Please let me know if there's anything else I should update 🙇

dmitris reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@BoomchainLabsBoomchainLabsBoomchainLabs approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@178inaba@krylov-krylov@dmitris@BoomchainLabs
[8]ページ先頭
©2009-2025 Movatter.jp