Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Problem matchers: Matches of test failures#422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
WillAbides wants to merge2 commits intoactions:main
base:main
Choose a base branch
Loading
fromWillAbides:main

Conversation

@WillAbides
Copy link

Description:

Currently test failures do not get annotated because the problem matcher requires that a column number be present, but go's test output does not include a column for test failures.

An example line that gets missed by the current matcher is:

/path/to/main_test.go:13: expected true but got false

The updated matcher makes the column number optional and matches the line above.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@WillAbidesWillAbides requested a review froma team as acode ownerSeptember 13, 2023 18:10
@dsamedsame self-assigned thisSep 18, 2023
@dsame
Copy link
Contributor

Hello@WillAbides , we are starting to review the PR

@WillAbides
Copy link
Author

You might want to hold off on this one for a bit. I used this same strategy in another action and gotthis report about it.

This pattern also matches test log statements, so those are getting annotated as failures even when the test passes.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@dsamedsamedsame approved these changes

@marko-zivic-93marko-zivic-93marko-zivic-93 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@dsamedsame

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WillAbides@dsame@marko-zivic-93

[8]ページ先頭

©2009-2025 Movatter.jp