- Notifications
You must be signed in to change notification settings - Fork613
Problem matchers: Matches of test failures#422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
WillAbides wants to merge2 commits intoactions:mainChoose a base branch fromWillAbides:main
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Hello@WillAbides , we are starting to review the PR |
dsame approved these changesSep 19, 2023
marko-zivic-93 approved these changesSep 20, 2023
You might want to hold off on this one for a bit. I used this same strategy in another action and gotthis report about it. This pattern also matches test log statements, so those are getting annotated as failures even when the test passes. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently test failures do not get annotated because the problem matcher requires that a column number be present, but go's test output does not include a column for test failures.
An example line that gets missed by the current matcher is:
The updated matcher makes the column number optional and matches the line above.
Check list: