- Notifications
You must be signed in to change notification settings - Fork77
#226: Added a better Workflow Pod readiness check#259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
#226: Added a better Workflow Pod readiness check#259
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Enhances the Workflow Pod readiness check by implementing a more comprehensive state validation system that checks both pod phases and conditions before executing workflow jobs.
- Introduces
PodConditionenum with comprehensive pod condition types - Adds new
waitForPodStateandwaitForPodToBeReadyfunctions for enhanced readiness validation - Replaces basic phase-only checking with combined phase and condition validation in
runContainerStep
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/k8s/src/k8s/utils.ts | Adds PodCondition enum defining Kubernetes pod condition types |
| packages/k8s/src/k8s/index.ts | Implements enhanced pod state checking functions with condition validation |
| packages/k8s/src/hooks/run-container-step.ts | Updates container step execution to use improved readiness check |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This change enchants the Workflow Pod readiness check by ensuring the proper phase and state of the Pod. This check is running during the
runContainerStep. This enables us to run status and readiness probe checks of the containers before executing the workflow job, ensuring the true readiness of the running containers and removing potential issues. It will also allow users to run scripts before the workflow job begins, such as running a DinD sidecar container and waiting for it to launch the daemon via the startup or readiness container probes.