- Notifications
You must be signed in to change notification settings - Fork77
fix: enable stdin on exec. fixes kata containers output#231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Enable stdin forwarding inexecPodStep calls to address truncated output when running against Kata containers.
- Pass
process.stdintoexecPodStepin the Alpine check helper. - Include
process.stdinin therunScriptStephook invocation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/k8s/src/k8s/index.ts | Passprocess.stdin intoexecPodStep for the Alpine check |
| packages/k8s/src/hooks/run-script-step.ts | Forwardprocess.stdin when invokingexecPodStep inrunScriptStep |
Comments suppressed due to low confidence (3)
packages/k8s/src/k8s/index.ts:529
- This change enables passing stdin to execPodStep for Kata containers; consider adding or updating tests to verify that stdin is forwarded correctly in both standard and Kata container environments.
process.stdinpackages/k8s/src/hooks/run-script-step.ts:30
- Consider adding or updating tests for runScriptStep to ensure that passing process.stdin to execPodStep correctly handles interactive input scenarios, especially with Kata containers.
process.stdinpackages/k8s/src/hooks/run-script-step.ts:30
- [nitpick] Since multiple callers now explicitly pass process.stdin, consider making process.stdin the default value for the stdin parameter in execPodStep, removing the need for callers to pass it each time.
process.stdinSigned-off-by: Maxime Bertin <mbertin@luccasoftware.com>
Context
When running the github hook against
katacontainers, the script output cannot be fetched properly from kata. Only a bit of the stdout/stderr are properly forwarded to GHWorkaround thisissue from kata
Resolution
Enabling stdin solves that issue and should not impact other workloads