- Notifications
You must be signed in to change notification settings - Fork77
Add debug trace for library#159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hey@timmjd, Thank you so much for the great work you put in to make this change. I will set aside some time this week or next week to go through these changes, but from the glimpse of it, it seems like a very useful addition to the hook! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please fix types in tests. They can be fixed with simpleas Type. Other than that, this looks good to me
As aself hosted runner administrator i want so know why my runners are crashing. If this is related to k8s, a stack trace often does help to pin down the origin of the issue.
Therefore, this change does improve the debug capability of the k8s hook implementation by providing a stack trace via the debug output if an exception happend.
Before the change
After the change
Change summary
The primary change is to enable a correct
sourceMapoutput for the code, so the stack trace will show up the.tsorigin with the correct line number of the trace and not some location within the minified / bakedindex.js.packages/hookliband thepackages/k8sandpackages/dockerwas changed from a JS based include into a TypeScript composite build. To make this happen, thebaseUrl&rootUrlrequired adaptation.tscfollowed bynccwas replaced with a direct call ofnccdue to otherwise the line number reference got lost.k8s/package.jsonthat appear now due to the linkage is happening now on a typed based linkage. I guess there was also a bug within themainContainerContextPorts[port.containerPort]assignment.nccandtypescriptlibrary update was required due to the used version caused a bug.