Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add debug trace for library#159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
timmjd wants to merge12 commits intoactions:main
base:main
Choose a base branch
Loading
fromtimmjd:feature/error_tracing

Conversation

@timmjd
Copy link

As aself hosted runner administrator i want so know why my runners are crashing. If this is related to k8s, a stack trace often does help to pin down the origin of the issue.

Therefore, this change does improve the debug capability of the k8s hook implementation by providing a stack trace via the debug output if an exception happend.

Before the change

before

After the change

after

Change summary

The primary change is to enable a correctsourceMap output for the code, so the stack trace will show up the.ts origin with the correct line number of the trace and not some location within the minified / bakedindex.js.

  • The linkage between thepackages/hooklib and thepackages/k8s andpackages/docker was changed from a JS based include into a TypeScript composite build. To make this happen, thebaseUrl &rootUrl required adaptation.
  • The build by using a combination oftsc followed byncc was replaced with a direct call ofncc due to otherwise the line number reference got lost.
  • There where some type inconsistencies that pop up within thek8s/package.json that appear now due to the linkage is happening now on a typed based linkage. I guess there was also a bug within themainContainerContextPorts[port.containerPort] assignment.
  • ncc andtypescript library update was required due to the used version caused a bug.

triangletodd reacted with thumbs up emoji
@nikola-jokic
Copy link
Collaborator

Hey@timmjd,

Thank you so much for the great work you put in to make this change. I will set aside some time this week or next week to go through these changes, but from the glimpse of it, it seems like a very useful addition to the hook!

Copy link
Collaborator

@nikola-jokicnikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please fix types in tests. They can be fixed with simpleas Type. Other than that, this looks good to me

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nikola-jokicnikola-jokicnikola-jokic requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timmjd@nikola-jokic

[8]ページ先頭

©2009-2025 Movatter.jp