- Notifications
You must be signed in to change notification settings - Fork455
Documentation Update - add permissions section to readme#511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -132,6 +132,26 @@ By default, the following status codes will not be retried: `400, 401, 403, 404, | ||||||||||||||||||||||||||||||||||||||
These retries are implemented using the [octokit/plugin-retry.js](https://github.com/octokit/plugin-retry.js) plugin. The retries use [exponential backoff](https://en.wikipedia.org/wiki/Exponential_backoff) to space out retries. ([source](https://github.com/octokit/plugin-retry.js/blob/9a2443746c350b3beedec35cf26e197ea318a261/src/error-request.ts#L13)) | ||||||||||||||||||||||||||||||||||||||
## Recommended Permissions | ||||||||||||||||||||||||||||||||||||||
The permissions required for the `GITHUB_TOKEN` in your workflow vary depending on how you use `github-script`. To ensure secure and efficient use of this action, we recommend reviewing and setting the least privileges necessary for your use case. | ||||||||||||||||||||||||||||||||||||||
### Determine the Required Permissions | ||||||||||||||||||||||||||||||||||||||
1. **`GITHUB_TOKEN` Authentication** | ||||||||||||||||||||||||||||||||||||||
GitHub automatically provides a `GITHUB_TOKEN` for workflows. You can customize the permissions granted to this token. Refer to the documentation for details: | ||||||||||||||||||||||||||||||||||||||
[Permissions for the `GITHUB_TOKEN`](https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) | ||||||||||||||||||||||||||||||||||||||
2. **API Calls with Installation Access Tokens** | ||||||||||||||||||||||||||||||||||||||
If you're using `github-script` to make API calls requiring installation access tokens, ensure the permissions are configured appropriately for those endpoints. Learn more here: | ||||||||||||||||||||||||||||||||||||||
[Permissions for installation access tokens](https://docs.github.com/en/rest/authentication/endpoints-available-for-github-app-installation-access-tokens) | ||||||||||||||||||||||||||||||||||||||
Comment on lines +135 to +147 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I think we can simplify this a bit Suggested change
| ||||||||||||||||||||||||||||||||||||||
### General Best Practices | ||||||||||||||||||||||||||||||||||||||
- Use the principle of least privilege: Only grant the specific permissions needed for your workflow. | ||||||||||||||||||||||||||||||||||||||
- Regularly audit and review your workflows to ensure permissions remain appropriate for your use cases. | ||||||||||||||||||||||||||||||||||||||
- Test your workflows with the intended permissions to verify they work as expected without over-permissioning. | ||||||||||||||||||||||||||||||||||||||
Comment on lines +149 to +153 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I'd remove this section personally - this would be betters suited in our GitHub documentation for Actions best practices rather than in this action's README. | ||||||||||||||||||||||||||||||||||||||
## Examples | ||||||||||||||||||||||||||||||||||||||
Note that `github-token` is optional in this action, and the input is there | ||||||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading.Please reload this page.