- Notifications
You must be signed in to change notification settings - Fork455
fix import path for github-script in README#495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -437,7 +437,7 @@ $ npm i -D @types/github-script@github:actions/github-script | |||
| And then add the `jsDoc` declaration to your script like this: | |||
| ```js | |||
| // @ts-check | |||
| /** @param {import('@types/github-script').AsyncFunctionArguments} AsyncFunctionArguments */ | |||
| /** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this not need to match the installed dependency above?
npm i -D @types/github-script@github:actions/github-script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The@types packages are automatically mapped to the packages with@types stripped off.
And importing@types/github-script causes error TS6137. Rewriting togithub-script resolves this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How you doing?
| @@ -437,7 +437,7 @@ $ npm i -D @types/github-script@github:actions/github-script | |||
| And then add the `jsDoc` declaration to your script like this: | |||
| ```js | |||
| // @ts-check | |||
| /** @param {import('@types/github-script').AsyncFunctionArguments} AsyncFunctionArguments */ | |||
| /** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How you doing?
No description provided.