Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix README error#392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dslatkin wants to merge3 commits intoactions:main
base:main
Choose a base branch
Loading
fromdslatkin:fix-readme-error
Open

Conversation

dslatkin
Copy link

I was using the example from the README to setup an async script in a workflow and got this error from the API:

Unhandled error: HttpError: No commit found for SHA: undefined

Digging a bit deeper, I discovered thatprocess.env.SHA didn't exist, and should probably beGITHUB_SHA instead. Swapping it out to this worked.

@dslatkindslatkin requested a review froma teamJune 2, 2023 02:38
joshmgross
joshmgross previously approved these changesNov 13, 2023
Copy link
Member

@joshmgrossjoshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I believe this example was intending the SHA to be set as an input

      -uses:actions/github-script@v6env:SHA:'${{env.parentSHA}}'with:script:|            const script = require('./path/to/script.js')            await script({github, context, core})

Soprocess.env.SHA wasn't meant to directly match an existingvariable in the context likeGITHUB_SHA

@dslatkin
Copy link
Author

That makes sense. I'm not sure I seeparentSHA defined anywhere, either. Would it make sense to removelines 341-342 in that case as well to reduce confusion? Thank you for reviewing!

@dslatkindslatkin requested a review froma team as acode ownerNovember 28, 2023 20:44
@dslatkin
Copy link
Author

That makes sense. I'm not sure I seeparentSHA defined anywhere, either. Would it make sense to removelines 341-342 in that case as well to reduce confusion? Thank you for reviewing!

Just a heads up, I did just remove these lines in a new commit.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@joshmgrossjoshmgrossjoshmgross left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dslatkin@joshmgross
[8]ページ先頭
©2009-2025 Movatter.jp